From: Kalle Valo <kvalo@codeaurora.org>
To: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
Cc: ath11k@lists.infradead.org
Subject: Re: [PATCH] ath11k/dp_tx: Remove endian conversion in HTT_H2T_MSG_TYPE_RX_RING_SELECTION_CFG
Date: Thu, 6 Jun 2019 16:36:11 +0000 (UTC) [thread overview]
Message-ID: <20190606163612.00AB1615AB@smtp.codeaurora.org> (raw)
In-Reply-To: <1559559277-21696-1-git-send-email-vthiagar@codeaurora.org>
Vasanthakumar Thiagarajan <vthiagar@codeaurora.org> wrote:
> With copyengine performing byte-swap when host target endian is different,
> driver should not do any endian conversion over the messages going through
> any of the copyengines. Remove the endian conversion while sending
> HTT_H2T_MSG_TYPE_RX_RING_SELECTION_CFG, this also fixes the below sparse
> warnings.
>
> drivers/net/wireless/ath/ath11k/dp_tx.c:837:33: warning: incorrect type in assignment (different base types)
> drivers/net/wireless/ath/ath11k/dp_tx.c:837:33: expected unsigned int [usertype] pkt_type_en_flags0
> drivers/net/wireless/ath/ath11k/dp_tx.c:837:33: got restricted __le32 [usertype]
> drivers/net/wireless/ath/ath11k/dp_tx.c:838:33: warning: incorrect type in assignment (different base types)
> drivers/net/wireless/ath/ath11k/dp_tx.c:838:33: expected unsigned int [usertype] pkt_type_en_flags1
> drivers/net/wireless/ath/ath11k/dp_tx.c:838:33: got restricted __le32 [usertype]
> drivers/net/wireless/ath/ath11k/dp_tx.c:839:33: warning: incorrect type in assignment (different base types)
> drivers/net/wireless/ath/ath11k/dp_tx.c:839:33: expected unsigned int [usertype] pkt_type_en_flags2
> drivers/net/wireless/ath/ath11k/dp_tx.c:839:33: got restricted __le32 [usertype]
> drivers/net/wireless/ath/ath11k/dp_tx.c:840:33: warning: incorrect type in assignment (different base types)
> drivers/net/wireless/ath/ath11k/dp_tx.c:840:33: expected unsigned int [usertype] pkt_type_en_flags3
> drivers/net/wireless/ath/ath11k/dp_tx.c:840:33: got restricted __le32 [usertype]
> drivers/net/wireless/ath/ath11k/dp_tx.c:841:28: warning: incorrect type in assignment (different base types)
> drivers/net/wireless/ath/ath11k/dp_tx.c:841:28: expected unsigned int [usertype] rx_filter_tlv
> drivers/net/wireless/ath/ath11k/dp_tx.c:841:28: got restricted __le32 [usertype]
>
> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
Patch applied to ath.git, thanks.
3191e61b1618 ath11k/dp_tx: Remove endian conversion in HTT_H2T_MSG_TYPE_RX_RING_SELECTION_CFG
--
https://patchwork.kernel.org/patch/10972749/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
prev parent reply other threads:[~2019-06-06 16:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 10:54 [PATCH] ath11k/dp_tx: Remove endian conversion in HTT_H2T_MSG_TYPE_RX_RING_SELECTION_CFG Vasanthakumar Thiagarajan
2019-06-06 16:36 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606163612.00AB1615AB@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=vthiagar@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox