Re: [PATCH V3 2/5] mac80211: rename csa counters to countdown counters

From: kernel test robot <lkp@intel.com>
To: John Crispin <john@phrozen.org>,
	Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, kbuild-all@lists.01.org,
	ath11k@lists.infradead.org
Subject: Re: [PATCH V3 2/5] mac80211: rename csa counters to countdown counters
Date: Wed, 5 Aug 2020 21:52:16 +0800	[thread overview]
Message-ID: <202008052103.2E3jajl5%lkp@intel.com> (raw)
In-Reply-To: <20200805080220.2884582-2-john@phrozen.org>

[-- Attachment #1: Type: text/plain, Size: 4739 bytes --]

Hi John,

I love your patch! Yet something to improve:

[auto build test ERROR on mac80211-next/master]
[also build test ERROR on mac80211/master ath6kl/ath-next wireless-drivers-next/master wireless-drivers/master v5.8 next-20200804]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/John-Crispin/nl80211-rename-csa-counter-attributes-countdown-counters/20200805-161354
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/net/wireless/mac80211_hwsim.c: In function 'mac80211_hwsim_beacon_tx':
>> drivers/net/wireless/mac80211_hwsim.c:1702:25: error: implicit declaration of function 'ieee80211_beacon_counter_is_complete'; did you mean 'ieee80211_beacon_cntdwn_is_complete'? [-Werror=implicit-function-declaration]
    1702 |  if (vif->csa_active && ieee80211_beacon_counter_is_complete(vif))
         |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                         ieee80211_beacon_cntdwn_is_complete
   cc1: some warnings being treated as errors
--
   drivers/net/wireless/ath/ath9k/htc_drv_beacon.c: In function 'ath9k_htc_csa_is_finished':
>> drivers/net/wireless/ath/ath9k/htc_drv_beacon.c:517:7: error: implicit declaration of function 'ieee80211_beacon_counter_is_complete'; did you mean 'ieee80211_beacon_cntdwn_is_complete'? [-Werror=implicit-function-declaration]
     517 |  if (!ieee80211_beacon_counter_is_complete(vif))
         |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |       ieee80211_beacon_cntdwn_is_complete
   cc1: some warnings being treated as errors
--
   drivers/net/wireless/ath/ath9k/beacon.c: In function 'ath9k_csa_is_finished':
>> drivers/net/wireless/ath/ath9k/beacon.c:368:7: error: implicit declaration of function 'ieee80211_beacon_counter_is_complete'; did you mean 'ieee80211_beacon_cntdwn_is_complete'? [-Werror=implicit-function-declaration]
     368 |  if (!ieee80211_beacon_counter_is_complete(vif))
         |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |       ieee80211_beacon_cntdwn_is_complete
   cc1: some warnings being treated as errors

vim +1702 drivers/net/wireless/mac80211_hwsim.c

  1657	
  1658	static void mac80211_hwsim_beacon_tx(void *arg, u8 *mac,
  1659					     struct ieee80211_vif *vif)
  1660	{
  1661		struct mac80211_hwsim_data *data = arg;
  1662		struct ieee80211_hw *hw = data->hw;
  1663		struct ieee80211_tx_info *info;
  1664		struct ieee80211_rate *txrate;
  1665		struct ieee80211_mgmt *mgmt;
  1666		struct sk_buff *skb;
  1667	
  1668		hwsim_check_magic(vif);
  1669	
  1670		if (vif->type != NL80211_IFTYPE_AP &&
  1671		    vif->type != NL80211_IFTYPE_MESH_POINT &&
  1672		    vif->type != NL80211_IFTYPE_ADHOC &&
  1673		    vif->type != NL80211_IFTYPE_OCB)
  1674			return;
  1675	
  1676		skb = ieee80211_beacon_get(hw, vif);
  1677		if (skb == NULL)
  1678			return;
  1679		info = IEEE80211_SKB_CB(skb);
  1680		if (ieee80211_hw_check(hw, SUPPORTS_RC_TABLE))
  1681			ieee80211_get_tx_rates(vif, NULL, skb,
  1682					       info->control.rates,
  1683					       ARRAY_SIZE(info->control.rates));
  1684	
  1685		txrate = ieee80211_get_tx_rate(hw, info);
  1686	
  1687		mgmt = (struct ieee80211_mgmt *) skb->data;
  1688		/* fake header transmission time */
  1689		data->abs_bcn_ts = mac80211_hwsim_get_tsf_raw();
  1690		mgmt->u.beacon.timestamp = cpu_to_le64(data->abs_bcn_ts +
  1691						       data->tsf_offset +
  1692						       24 * 8 * 10 / txrate->bitrate);
  1693	
  1694		mac80211_hwsim_tx_frame(hw, skb,
  1695					rcu_dereference(vif->chanctx_conf)->def.chan);
  1696	
  1697		while ((skb = ieee80211_get_buffered_bc(hw, vif)) != NULL) {
  1698			mac80211_hwsim_tx_frame(hw, skb,
  1699					rcu_dereference(vif->chanctx_conf)->def.chan);
  1700		}
  1701	
> 1702		if (vif->csa_active && ieee80211_beacon_counter_is_complete(vif))
  1703			ieee80211_csa_finish(vif);
  1704	}
  1705	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 64446 bytes --]

[-- Attachment #3: Type: text/plain, Size: 102 bytes --]

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k