From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Thu, 10 Dec 2020 20:58:55 +0100 From: Wolfram Sang Subject: Re: [PATCH] dma-mapping: move hint unlikely for dma_mapping_error from drivers to core Message-ID: <20201210195855.GA11120@kunai> References: <5d08af46-5897-b827-dcfb-181d869c8f71@gmail.com> MIME-Version: 1.0 In-Reply-To: <5d08af46-5897-b827-dcfb-181d869c8f71@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0168737732440424236==" Sender: "ath11k" Errors-To: ath11k-bounces+kvalo=adurom.com@lists.infradead.org To: Heiner Kallweit Cc: Kevin Brace , Shyam Sundar S K , Igor Russkikh , Iyappan Subramanian , GR-everest-linux-l2@marvell.com, Ioana Radulescu , Madalin Bucur , Michal Simek , Doug Ledford , Murali Karicheri , Mark Lee , Jiri Pirko , Jesper Dangaard Brouer , Hauke Mehrtens , Arnaud Ebalard , Lorenzo Bianconi , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Guy Tzalik , Luis Chamberlain , linux-crypto@vger.kernel.org, Jon Mason , Shannon Nelson , Kunihiko Hayashi , Chris Snook , Daniele Venzano , Zhu Yanjun , linux-i2c@vger.kernel.org, Ioana Ciornei , Jon Olson , Arthur Kiyanovski , Leon Romanovsky , "David S. Miller" , Boris Pismenny , John Fastabend , Rain River , Martin Habets , Yisen Zhuang , Wingman Kwok , Sean Wang , Claudiu Manoil , Pensando Drivers , Kalle Valo , Boris Brezillon , Sagi Shahar , Tariq Toukan , Sudarsana Kalluru , Netanel Belgazal , Andreas Larsson , Catherine Sullivan , Zaibo Xu , Mike Marciniszyn , Alexei Starovoitov , Elie Morisse , Luca Coelho , Quan Nguyen , Subbaraya Sundeep , Jiri Slaby , Daniel Borkmann , Dennis Dalessandro , linux-rdma@vger.kernel.org, Srujana Challa , ath10k@lists.infradead.org, linux-arm-kernel@lists.infradead.org, ath11k@lists.infradead.org, b43-dev@lists.infradead.org, Jay Cliburn , Radhey Shyam Pandey , John Crispin , Michael Chan , Salil Mehta , Edward Cree , iommu@lists.linux-foundation.org, wil6210@qti.qualcomm.com, Saeed Bishara , bpf@vger.kernel.org, Geetha sowjanya , Giovanni Cabiddu , Thomas Petazzoni , Herbert Xu , Zorik Machulsky , qat-linux@intel.com, Jason Gunthorpe , Nick Kossifidis , Jakub Kicinski , Nehal Shah , Sunil Goutham , Sebastian Hesselbarth , Ariel Elior , Keyur Chudgar , George Cherian , linux-mediatek@lists.infradead.org, Matthias Brugger , netdev@vger.kernel.org, hariprasad , Raju Rangoju , Felix Fietkau , Saeed Mahameed , Larry Finger --===============0168737732440424236== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="k+w/mQv8wyuph6w0" Content-Disposition: inline --k+w/mQv8wyuph6w0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 10, 2020 at 03:47:50PM +0100, Heiner Kallweit wrote: > Zillions of drivers use the unlikely() hint when checking the result of > dma_mapping_error(). This is an inline function anyway, so we can move > the hint into the function and remove it from drivers. > From time to time discussions pop up how effective unlikely() is, > and that it should be used only if something is really very unlikely. > I think that's the case here. >=20 > Patch was created with some help from coccinelle. >=20 > @@ > expression dev, dma_addr; > @@ >=20 > - unlikely(dma_mapping_error(dev, dma_addr)) > + dma_mapping_error(dev, dma_addr) >=20 > Signed-off-by: Heiner Kallweit Acked-by: Wolfram Sang # for I2C --k+w/mQv8wyuph6w0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl/SffoACgkQFA3kzBSg KbYcjxAAgOE4gHcgEP8+Oex1fposdP2Z4KiWFjIYYWG4fo/Ry9PjDbSGh9Nptht2 fnsCRcFXFj4oaSXaflBTq6ky4usgo2Gyp9puXbnpyj7P2uEjrqZs1zUFpAWdzMor UgiJkW/P2IZjCDfwxE8nn9L0fm8ZfcHWqVohAgDh/9SKsrQCdzlzwvd7vSQ94fXr qnYrmc6BF68dxVZx4TV18GddP5qFXYKytQ8pXL51XZEJTI05IGmc2l6hs/B4tKj6 muxiEFw5Ac0eseMimi4J5YDJJZxWe28onn69mMJYQDzVPqSZRyhSAqCv0EhMg6Vp sABbG/eShtxir8A5ZrVRgqCaVyBjPu6pHAxdccHkj4d/6hfvD6F2FDXXaWirAf3i A4gsMJAmxtBYV0Lyx0D+fzCFnvUSDDSOEayRJdzotQXVCbLvuWHTp6EXVJFD5mMU /o3LApTC1uYQTXfGh1HHanpSEXLXfVgzjuDHRUsVIwemk5JwUAl6fw4oXbMrHYdZ v9Inx4U81LGxayz1vGmzbE39AeE7YH/5lH4metjot96RpKa+Gg++mMxUHBPW6Jam AOz6I3cKYsn7mPkzAZfDNvhvfgz2vxXcGGULSCdaWnVCJY7FMqe8i98w1z/Ymo7U JSXmDUhFS43r0JqUfbR0sRGgLL+kHTEa6I4ZT8UNd9DmTtS0Jmo= =4X1P -----END PGP SIGNATURE----- --k+w/mQv8wyuph6w0-- --===============0168737732440424236== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k --===============0168737732440424236==--