From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08486C2B9F4 for ; Fri, 25 Jun 2021 05:29:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE2466140A for ; Fri, 25 Jun 2021 05:29:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE2466140A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uXLaA/kJgEUB+5TKpKJ4tfOIz9DVQ5T/lIDTLteMqQU=; b=LP9i2wUP90quQi N9SVkaQacV8XDOXwk+We5qcQvRkaU+5/UMW3L5e7d7805l/V5uK+V4x69v6fxWrh1n/tYegVSfRDa xbc42Y0Ijderoc9iU7grsPo+xyHXiVLwwCw/xKJlayaDjWFOpibclbRGf2GJdZdwn01BAiryZL4Je oOQuCmGy8nERZBuRDKKLMVmZFcEGsO+Y6WLsVDh63fAZAdhGwApUkqK1ECsd7QvY8stxrt5aL95tG 7mie6DVlXCNmkLOq3Fj68lrXkllpqG7ErU2FfWMLO7DJsJuyGaSLmWNIX3RdKSEXT0YpRN56SWkga wBVLeqzFaFwxKayML2dg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lweOi-00HJOT-2I; Fri, 25 Jun 2021 05:29:00 +0000 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lweOe-00HJO6-KF for ath11k@lists.infradead.org; Fri, 25 Jun 2021 05:28:58 +0000 Received: by mail-pg1-x532.google.com with SMTP id e20so6683724pgg.0 for ; Thu, 24 Jun 2021 22:28:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=uH4YEvmp5g7u93n9Dq2yTIhMcUrniJ3GekoEltOXyi0=; b=BWh1AVeR7HY31dhsptuFMdXnjvMV7kDmH0Lm8NCVFqXNGL+U+OAstSLqLf0vzL5TjU kHw58AdDMDAB7aSROhCCVa/+zIfRC38hzdVbOGxcpuv+bn/EK0EM2v5yqM6nRlzAmWyt NPis4x1Gr58EuzqIeu467LxXh9f4xHabKX7auC1na/14Fk35yLXT2h+CPe4qfeWtuEtB w+WgYiN6z+euS54vuxzJvB1bIIjDDjFHSd1bEWy4R3bNzG1d5sSy2uqkHte5/OHwJtZe K7WO0jDr5hvADqUqxSZPHEGmW/UF2Su1D3czDqjWIMJ6DfjUSZWqOYsMaQLyYd2+ifcG FAEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=uH4YEvmp5g7u93n9Dq2yTIhMcUrniJ3GekoEltOXyi0=; b=hYD4+smGYOKHyyooVcrg5jWc1L4/1BG7TmNXmOEb3VSefoXbrPsH274n+nhy4XXzEi kTHUFIJilBTtxcSE6H+2PjHEzbB/1XT78fSJO22HBOxvEHJCAAbhtNWmqBvn0xdPk9r+ sVUD5gVAwDRkB41F0H3TCxKzuPyBztNw90RHa7VYyekJyJ38YZqK8Ts09zyTQIPYHNzO fNoSHRModx5wOR6JAXoNKm60FzpF0hTTYsVUxpmVgNuUL8pghrw3tN4y7xjGzzvhpNvE TNSiRMtgGarWFSn/NqsHL13i3o0aDAM8iFd9XPzzqmYXzdJkMrZPtaDZ79FEDupRSefX tO3A== X-Gm-Message-State: AOAM532/pC2/3XjmAxBYkKUvuZfRsz2AzC2Gv8YihOaZ7Ps8VCsu5Cl9 y/QG2pd58RXc/fjiOUY4berK X-Google-Smtp-Source: ABdhPJxP31Y8odt9uYHFYA5YARCzn1gDkW177thP7cFAk7Q1JIRMzZxVqmXOzD51LDnm/kp0w86Vew== X-Received: by 2002:aa7:8684:0:b029:305:9474:6934 with SMTP id d4-20020aa786840000b029030594746934mr8533191pfo.45.1624598935313; Thu, 24 Jun 2021 22:28:55 -0700 (PDT) Received: from workstation ([120.138.13.204]) by smtp.gmail.com with ESMTPSA id g17sm4186329pfv.62.2021.06.24.22.28.52 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 24 Jun 2021 22:28:54 -0700 (PDT) Date: Fri, 25 Jun 2021 10:58:51 +0530 From: Manivannan Sadhasivam To: Bhaumik Bhatt Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org, jhugo@codeaurora.org, linux-kernel@vger.kernel.org, loic.poulain@linaro.org, linux-wireless@vger.kernel.org, kvalo@codeaurora.org, ath11k@lists.infradead.org Subject: Re: [PATCH v4 0/6] BHI/BHIe improvements for MHI power purposes Message-ID: <20210625052851.GF4974@workstation> References: <1620330705-40192-1-git-send-email-bbhatt@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1620330705-40192-1-git-send-email-bbhatt@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210624_222856_749983_AFC06AAA X-CRM114-Status: GOOD ( 21.78 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org On Thu, May 06, 2021 at 12:51:39PM -0700, Bhaumik Bhatt wrote: > This patch series improves the power up behavior by allowing MHI host driver to > set BHI and/or BHIe offsets early on in the preparation phase and fail pre-power > up if offsets are not found or not within a limited MMIO region. This also > allows MHI host to clean up the offsets in the unprepare after power down phase. > > Going forward, controllers will be required to specify a reg_len field which > will be used to check whether the BHI/BHIe offsets are in range or not. > > This series has been tested on X86_64 architecture with the PCI generic driver > as controller and an SDX55 device. > Since there is a chance to send this series for 5.14, I've applied it now to mhi-next! Thanks, Mani > v4: > -Added reviewed-by tags > -Updated range check patch to include BHI/e offsets in the error message > > v3: > -Added reviewed-by tags > -Updated order of reg_len in mhi_controller structure documentation > > v2: > -Added reviewed-by tags > -Moved reg_len entry in mhi_controller structure to allow for a packed struct > > Bhaumik Bhatt (6): > bus: mhi: core: Set BHI/BHIe offsets on power up preparation > bus: mhi: core: Set BHI and BHIe pointers to NULL in clean-up > bus: mhi: Add MMIO region length to controller structure > ath11k: set register access length for MHI driver > bus: mhi: pci_generic: Set register access length for MHI driver > bus: mhi: core: Add range checks for BHI and BHIe > > drivers/bus/mhi/core/init.c | 61 ++++++++++++++++++++++++----------- > drivers/bus/mhi/core/pm.c | 28 +++------------- > drivers/bus/mhi/pci_generic.c | 1 + > drivers/net/wireless/ath/ath11k/mhi.c | 1 + > include/linux/mhi.h | 2 ++ > 5 files changed, 50 insertions(+), 43 deletions(-) > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k