From: Christoph Hellwig <hch@lst.de>
To: Kalle Valo <kvalo@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, ath11k@lists.infradead.org
Subject: Re: ath11k vs ar_qrtr?
Date: Wed, 30 Nov 2022 13:52:36 +0100 [thread overview]
Message-ID: <20221130125236.GA865@lst.de> (raw)
In-Reply-To: <87o7so4nr2.fsf@kernel.org>
On Wed, Nov 30, 2022 at 02:42:41PM +0200, Kalle Valo wrote:
> Sorry, not following you here. Are you saying that "select QRTR" is not
> enough and we should add something more?
Yes, there is no runtime dependency right now. Something like
using MODULE_SOFTDEP should solve this. Untested for now, but I can
send a formal one after I make it past the initial installation:
diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
index b99180bc81723b..72d043fc6b7c2c 100644
--- a/drivers/net/wireless/ath/ath11k/core.c
+++ b/drivers/net/wireless/ath/ath11k/core.c
@@ -1945,3 +1945,5 @@ EXPORT_SYMBOL(ath11k_core_alloc);
MODULE_DESCRIPTION("Core module for Qualcomm Atheros 802.11ax wireless LAN cards.");
MODULE_LICENSE("Dual BSD/GPL");
+MODULE_SOFTDEP("pre: qrtr");
+MODULE_SOFTDEP("pre: qrtr-mhi");
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2022-11-30 12:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 12:28 ath11k vs ar_qrtr? Christoph Hellwig
2022-11-30 12:42 ` Kalle Valo
2022-11-30 12:52 ` Christoph Hellwig [this message]
2022-11-30 13:12 ` Kalle Valo
2022-11-30 13:22 ` Christoph Hellwig
2022-11-30 17:18 ` Kalle Valo
2022-11-30 13:30 ` failed to insert STA entry for the AP (error -2) Christoph Hellwig
2022-12-02 18:46 ` Kalle Valo
2022-12-03 15:52 ` Christoph Hellwig
2022-12-07 12:49 ` Kalle Valo
2022-12-07 13:40 ` Christoph Hellwig
2022-12-07 14:24 ` Cyril Brulebois
2022-12-08 18:44 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221130125236.GA865@lst.de \
--to=hch@lst.de \
--cc=ath11k@lists.infradead.org \
--cc=kvalo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox