ATH11K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arowa Suliman <arowa@chromium.org>
To: ath11k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org, Arowa Suliman <arowa@google.com>,
	kernel test robot <lkp@intel.com>
Subject: [PATCH] wifi: ath11k: Add crash logging
Date: Mon, 10 Jul 2023 16:04:53 -0700	[thread overview]
Message-ID: <20230710230546.3544912-1-arowa@google.com> (raw)

Change crash logging from debug to informational and add warning when
firmware crash MHI_CB_EE_RDDM happens.

Tested-on: Qualcomm WCN6855
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202306141105.c1e82Q0y-lkp@intel.com/
Signed-off-by: Arowa Suliman <arowa@google.com>
---
 drivers/net/wireless/ath/ath11k/mhi.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath11k/mhi.c b/drivers/net/wireless/ath/ath11k/mhi.c
index 3ac689f1def4..5db4b61c1cba 100644
--- a/drivers/net/wireless/ath/ath11k/mhi.c
+++ b/drivers/net/wireless/ath/ath11k/mhi.c
@@ -325,7 +325,7 @@ static void ath11k_mhi_op_status_cb(struct mhi_controller *mhi_cntrl,
 {
 	struct ath11k_base *ab = dev_get_drvdata(mhi_cntrl->cntrl_dev);
 
-	ath11k_dbg(ab, ATH11K_DBG_BOOT, "notify status reason %s\n",
+        ath11k_info(ab, "notify status reason %s\n",
 		   ath11k_mhi_op_callback_to_str(cb));
 
 	switch (cb) {
@@ -333,7 +333,8 @@ static void ath11k_mhi_op_status_cb(struct mhi_controller *mhi_cntrl,
 		ath11k_warn(ab, "firmware crashed: MHI_CB_SYS_ERROR\n");
 		break;
 	case MHI_CB_EE_RDDM:
-		if (!(test_bit(ATH11K_FLAG_UNREGISTERING, &ab->dev_flags)))
+		ath11k_warn(ab, "firmware crashed: MHI_CB_EE_RDDM\n");
+                if (!(test_bit(ATH11K_FLAG_UNREGISTERING, &ab->dev_flags)))
 			queue_work(ab->workqueue_aux, &ab->reset_work);
 		break;
 	default:
-- 
2.41.0.255.g8b1d071c50-goog


-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

             reply	other threads:[~2023-07-10 23:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-10 23:04 Arowa Suliman [this message]
2023-07-11  6:40 ` [PATCH] wifi: ath11k: Add crash logging Kalle Valo
  -- strict thread matches above, loose matches on Subject: below --
2023-06-14  2:29 Arowa Suliman
2023-06-14  4:01 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230710230546.3544912-1-arowa@google.com \
    --to=arowa@chromium.org \
    --cc=arowa@google.com \
    --cc=ath11k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox