From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B521C27C78 for ; Tue, 11 Jun 2024 22:55:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=cYHTv+h+1UsSvEa4km5zLBd2NSwT44Y7Dxj9evrCJ/4=; b=yKvhFNYF1VtV2W 1uraUV14Ymfdhb4JEj1YCjqFVzvQuZkXwsGlJ0tp2o5biwXGHifQnpGZEcUXjdrvoVTwMpbDItDVZ GUPdw7bB6tQvu9+nclZDP7ne8XY6txFjbk2pecSpcKIzgbAkpM/mko8OrBTX3/DY2A+E2/qkEygkx kjV2M7ZtN4xnRTvbOPygqeG74qffO1DqEzTX+sbJg5uhexsX8RRZdzOI6/bHcM1xP/AxwmqDXFXFh 7EcUvBc8DPUTmdvkh4rz9EIefpZ4by8K6GNwyGBdmGRF8fZwAoTkO5uqw5l1NeZRxLnen1Zke7A3x zj47Ph+m2LLTs2TviPpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHAP5-0000000AS1H-43Fq; Tue, 11 Jun 2024 22:55:47 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHAP2-0000000ARzS-3NfM; Tue, 11 Jun 2024 22:55:46 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D47ED60E88; Tue, 11 Jun 2024 22:55:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A0C9C2BD10; Tue, 11 Jun 2024 22:55:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718146543; bh=tfmwzXhu9BMvZdNucjHAIFq8O+nZOSTOqKttExZG0P0=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=A7pxdhgDNwl0CRAVasMm9Q18XFML4ebWwMMtwSRB078ntHxIYEfNrp+4t38McKEym 9Mbu/3WwIfhYbMrZlqu3YigWp9p6tLAcrQ8t8fNDVsrNom4keCoxM5P2uaoc3BisfH Tv1NvrM/CehSzwVFu7gHEYo1MtWv8/9ofoqWcwm7ZwZWCaMHSTgriGAA44d3oC9/l7 xfGAWXlG8hZSKHlh+CZUcvtc3MgVBnyhPwXZyg9L3FuzoLkKbLX0T6yyh1Iyx8D2xA 1r/7dxQE3RbzF2CaEURzoqsdakZBbpuAmP7pxyBtCIwFhtSV5lL1BUgyKr8wESuNwO 493hSgD34nxaw== Date: Tue, 11 Jun 2024 17:55:41 -0500 From: Bjorn Helgaas To: Bartosz Golaszewski Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marcel Holtmann , Luiz Augusto von Dentz , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Balakrishna Godavarthi , Rocky Liao , Kalle Valo , Jeff Johnson , Bjorn Andersson , Konrad Dybcio , Bjorn Helgaas , Srini Kandagatla , Elliot Berman , Caleb Connolly , Neil Armstrong , Dmitry Baryshkov , Alex Elder , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, Jeff Johnson , ath12k@lists.infradead.org, linux-pm@vger.kernel.org, linux-pci@vger.kernel.org, Bartosz Golaszewski , kernel@quicinc.com, Amit Pundir Subject: Re: [PATCH v8 12/17] PCI: hold the rescan mutex when scanning for the first time Message-ID: <20240611225541.GA1005771@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240528-pwrseq-v8-12-d354d52b763c@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240611_155544_917255_EFD0155E X-CRM114-Status: GOOD ( 14.88 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org On Tue, May 28, 2024 at 09:03:20PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > With the introduction of PCI device power control drivers that will be > able to trigger the port rescan when probing, we need to hold the rescan > mutex during the initial pci_host_probe() too or the two could get in > each other's way. > > Tested-by: Amit Pundir > Signed-off-by: Bartosz Golaszewski With s/hold the/Hold the/ in subject to match history, Acked-by: Bjorn Helgaas > --- > drivers/pci/probe.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c > index 8e696e547565..604fc96b1098 100644 > --- a/drivers/pci/probe.c > +++ b/drivers/pci/probe.c > @@ -3072,7 +3072,9 @@ int pci_host_probe(struct pci_host_bridge *bridge) > struct pci_bus *bus, *child; > int ret; > > + pci_lock_rescan_remove(); > ret = pci_scan_root_bus_bridge(bridge); > + pci_unlock_rescan_remove(); > if (ret < 0) { > dev_err(bridge->dev.parent, "Scanning root bridge failed"); > return ret; > > -- > 2.43.0 >