From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31A6DC44501 for ; Tue, 14 Jul 2026 16:02:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:content-type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/HD+/nSixqFwhUNrYPVI+z6DSeUlu21xZXSgevbF+e4=; b=SgssCSB6hTEZI214SV60dvnWYS KX99mhHknnefQ+sTG/55eKhxVpZ9BelhbpKRg65UX2vj7f2F5Z2Ptj049vdqQb7BqwrXv2L59WRQU 4MUs23LA2bigqoCloFiYmOPK2PI1nrYVmLut+jJpl3AxGFAChy2XScg7KjAGqyWs7/P/toVdmxH5Y 1w7swz8LrgENdw7Cz7aZtTb/vBOvCPH7M5TNND5fj6HTq228YB9HZJjDMLKEJ/g783Ie65CoAAyZ1 UU6HhuPOXG/UKNDiKU/aCz+emgdAdTFRA8Yq60nF+0SvT9qiufrxk9g9o+Gv2YJZm7FKb2HWRM7O6 wlcG8EHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjfav-0000000CcKB-1TXa; Tue, 14 Jul 2026 16:02:53 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjfas-0000000CcJF-1CWF for ath11k@lists.infradead.org; Tue, 14 Jul 2026 16:02:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784044969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/HD+/nSixqFwhUNrYPVI+z6DSeUlu21xZXSgevbF+e4=; b=WSIL+GLqzT9EwCySyA4U2it70mRvowY4u6QNUtFSW+iDYQKQOwJG37TJUtxwJQ4nTJcnr3 xibXrBxHNXKhr2+NbTtymNkcuDP6hGFGkzSObqoHWSh/cLsEskmSaxHxoqQQsid0WEgyKR L4K5/+c7dlMqRmv9VJded/MxPZ+cHM4= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-347-mGULl9C1N_i7T2PYcjMyGQ-1; Tue, 14 Jul 2026 12:02:45 -0400 X-MC-Unique: mGULl9C1N_i7T2PYcjMyGQ-1 X-Mimecast-MFC-AGG-ID: mGULl9C1N_i7T2PYcjMyGQ_1784044964 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C572D180025A; Tue, 14 Jul 2026 16:02:43 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.44.48.50]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7833A414; Tue, 14 Jul 2026 16:02:40 +0000 (UTC) From: Jose Ignacio Tornos Martinez To: hujy652@gmail.com Cc: ath11k@lists.infradead.org, ath12k@lists.infradead.org, jjohnson@kernel.org, jtornosm@redhat.com, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH 1/2] wifi: ath11k: implement custom wake_tx_queue with flow control Date: Tue, 14 Jul 2026 18:02:38 +0200 Message-ID: <20260714160238.664089-1-jtornosm@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 X-Mimecast-MFC-PROC-ID: XXdU2fwb2qQFdES1vfDOeRappoSELWKC0DqvA6I9hJk_1784044964 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260714_090250_391754_BD4F1B85 X-CRM114-Status: UNSURE ( 8.68 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org Hi Zhi-Jun, > While you are reworking it would you mind looking at the previous attempt? > > It tried to follow the behaviour in ath10k but lacks throttling mechanism. > > https://lore.kernel.org/linux-wireless/20230501130725.7171-1-quic_tamizhr@quicinc.com/ Thanks for the pointer. I have looked at Tamizh's patch and the main difference with this approach is that the ring free space check is done before dequeuing, so the skb is never consumed when the ring is full. This avoids frame drops and the -ENOMEM errors we were seeing. I think no additional push mechanism from TX completions is needed since wake_tx_queue is called frequently enough under traffic to resume dequeuing when ring space becomes available. Best regards, Jose Ignacio