From: Sven Eckelmann <sven@narfation.org>
To: ath11k@lists.infradead.org
Cc: Kalle Valo <kvalo@codeaurora.org>
Subject: Re: [PATCH] ath11k: move per peer pktlog entry to per sta debugfs
Date: Wed, 24 Apr 2019 11:48:29 +0200 [thread overview]
Message-ID: <25124618.P5zsotkJkX@bentobox> (raw)
In-Reply-To: <b7fb612b6fe0c9130d8a60c87fd93f90@codeaurora.org>
[-- Attachment #1.1: Type: text/plain, Size: 1686 bytes --]
On Wednesday, 24 April 2019 11:04:19 CEST Anilkumar Kolli wrote:
[...]
> >> Does not compile:
> >>
> >> drivers/net/wireless/ath/ath11k/debugfs_sta.c:455:11: error:
> >> initialization of 'ssize_t (*)(struct file *, const char *, size_t,
> >> loff_t *)' {aka 'long int (*)(struct file *, const char *, long
> >> unsigned int, long long int *)'} from incompatible pointer type
> >> 'ssize_t (*)(struct file *, char *, size_t, loff_t *)' {aka 'long int
> >> (*)(struct file *, char *, long unsigned int, long long int *)'}
> >> [-Werror=incompatible-pointer-types]
> >> .write = ath11k_dbg_sta_write_peer_pktlog,
> >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > I am using "arch/x86/configs/x86_64_defconfig" and ath11k enabled,
> > could not reproduce this issue.
> > Kindly share the build instructions.
Not sure what kernel you compile against but the second argument (ubuf) is a
const since a long time (before the history of the git repo starts). I can not
tell you since when GCC checks the constness for function pointers. But try to
upgrade to something recent like GCC 8.
> My build machine configs,
> ./ath10k-check --version
> ath10k-check (md5sum 5d3d5f426267bdc0a18e038d2f691a74)
>
> gcc: gcc (Ubuntu 4.8.4-2ubuntu1~14.04.4) 4.8.4
> sparse: 0.4.5-rc1
> checkpatch.pl: Version: 0.32 (md5sum 3a4f482bde0f92cd08f79fca7efd2a71)
> gtags: gtags - GNU GLOBAL 5.7.1
Btw. you should really think about not using such old components. Ever though
about upgrading your system from a nearly EOL [1] ubuntu version from 2014 to
something more recent?
Kind regards,
Sven
[1] https://blog.ubuntu.com/2019/02/05/ubuntu-14-04-trusty-tahr
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 146 bytes --]
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2019-04-24 9:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 4:41 [PATCH] ath11k: move per peer pktlog entry to per sta debugfs Anilkumar Kolli
2019-04-23 14:14 ` Kalle Valo
2019-04-24 7:38 ` Anilkumar Kolli
2019-04-24 9:04 ` Anilkumar Kolli
2019-04-24 9:48 ` Sven Eckelmann [this message]
2019-05-02 14:53 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25124618.P5zsotkJkX@bentobox \
--to=sven@narfation.org \
--cc=ath11k@lists.infradead.org \
--cc=kvalo@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox