From: Peter Oh <peter.oh@eero.com>
To: P Praneesh <ppranees@codeaurora.org>, kvalo@codeaurora.org
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
Karthikeyan Periyasamy <periyasa@codeaurora.org>,
Jouni Malinen <jouni@codeaurora.org>
Subject: Re: [PATCH v2 12/12] ath11k: avoid unnecessary lock contention in tx_completion path
Date: Wed, 25 Aug 2021 14:56:12 -0700 [thread overview]
Message-ID: <288e574d-0de0-9002-b853-5fa1db3bd3f7@eero.com> (raw)
In-Reply-To: <1629884277-18759-13-git-send-email-ppranees@codeaurora.org>
On 8/25/21 2:37 AM, P Praneesh wrote:
> @@ -584,16 +580,15 @@ void ath11k_dp_tx_completion_handler(struct ath11k_base *ab, int ring_id)
> continue;
> }
>
> - spin_lock_bh(&tx_ring->tx_idr_lock);
> - msdu = idr_find(&tx_ring->txbuf_idr, msdu_id);
missing spin_lock(&tx_ring->tx_idr_lock);here?
> + msdu = idr_remove(&tx_ring->txbuf_idr, msdu_id);
> if (unlikely(!msdu)) {
> ath11k_warn(ab, "tx completion for unknown msdu_id %d\n",
> msdu_id);
> - spin_unlock_bh(&tx_ring->tx_idr_lock);
> + spin_unlock(&tx_ring->tx_idr_lock);
> continue;
> }
> - idr_remove(&tx_ring->txbuf_idr, msdu_id);
> - spin_unlock_bh(&tx_ring->tx_idr_lock);
> +
> + spin_unlock(&tx_ring->tx_idr_lock);
>
> ar = ab->pdevs[mac_id].ar;
>
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
prev parent reply other threads:[~2021-08-25 21:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 9:37 [PATCH v2 00/12] ath11k: optimizations in data path P Praneesh
2021-08-25 9:37 ` [PATCH v2 01/12] ath11k: disable unused CE8 interrupts for ipq8074 P Praneesh
2021-08-25 9:37 ` [PATCH v2 02/12] ath11k: allocate dst ring descriptors from cacheable memory P Praneesh
2021-08-25 18:45 ` Peter Oh
2021-08-25 9:37 ` [PATCH v2 03/12] ath11k: modify dp_rx desc access wrapper calls inline P Praneesh
2021-08-25 9:37 ` [PATCH v2 04/12] ath11k: avoid additional access to ath11k_hal_srng_dst_num_free P Praneesh
2021-08-25 9:37 ` [PATCH v2 05/12] ath11k: avoid active pdev check for each msdu P Praneesh
2021-08-25 9:37 ` [PATCH v2 06/12] ath11k: remove usage quota while processing rx packets P Praneesh
2021-08-25 9:37 ` [PATCH v2 07/12] ath11k: add branch predictors in process_rx P Praneesh
2021-08-25 22:49 ` Sergey Ryazanov
2021-08-25 9:37 ` [PATCH v2 08/12] ath11k: allocate HAL_WBM2SW_RELEASE ring from cacheable memory P Praneesh
2021-08-25 9:37 ` [PATCH v2 09/12] ath11k: remove mod operator in dst ring processing P Praneesh
2021-08-25 9:37 ` [PATCH v2 10/12] ath11k: avoid while loop in ring selection of tx completion interrupt P Praneesh
2021-08-25 9:37 ` [PATCH v2 11/12] ath11k: add branch predictors in dp_tx path P Praneesh
2021-08-25 23:02 ` Sergey Ryazanov
2021-08-25 9:37 ` [PATCH v2 12/12] ath11k: avoid unnecessary lock contention in tx_completion path P Praneesh
2021-08-25 21:56 ` Peter Oh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=288e574d-0de0-9002-b853-5fa1db3bd3f7@eero.com \
--to=peter.oh@eero.com \
--cc=ath11k@lists.infradead.org \
--cc=jouni@codeaurora.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=periyasa@codeaurora.org \
--cc=ppranees@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox