From: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
To: Kalle Valo <kvalo@kernel.org>
Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
<devicetree@vger.kernel.org>, <robh@kernel.org>,
<mka@chromium.org>
Subject: Re: [PATCH v4 04/12] ath11k: Add register access logic for WCN6750
Date: Wed, 27 Apr 2022 11:23:52 +0530 [thread overview]
Message-ID: <2a18a4d3-254b-727e-e96d-90deec61571c@quicinc.com> (raw)
In-Reply-To: <87czh3gjuq.fsf@kernel.org>
On 4/27/2022 11:15 AM, Kalle Valo wrote:
> Manikanta Pubbisetty <quic_mpubbise@quicinc.com> writes:
>
>> WCN6750 uses static window mapping to access the HW registers.
>> Unlike QCN9074 which uses 2nd window for CE and 3rd window
>> for UMAC register accesses, WCN6750 uses 1st window for UMAC
>> and 2nd window for CE registers.
>>
>> Code is refactored so that WCN6750 can use the existing
>> ath11k_pci_read/write() APIs for accessing the registers.
>>
>> Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00573-QCAMSLSWPLZ-1
>> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1
>> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.5.0.1-01100-QCAHKSWPL_SILICONZ-1
>> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-00192-QCAHKSWPL_SILICONZ-1
>>
>> Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
>> ---
>> drivers/net/wireless/ath/ath11k/ahb.c | 3 ++
>> drivers/net/wireless/ath/ath11k/core.h | 2 +
>> drivers/net/wireless/ath/ath11k/pci.c | 4 ++
>> drivers/net/wireless/ath/ath11k/pcic.c | 53 +++++++++-----------------
>> 4 files changed, 28 insertions(+), 34 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c
>> index d73643e3e8dd..d27fc7276977 100644
>> --- a/drivers/net/wireless/ath/ath11k/ahb.c
>> +++ b/drivers/net/wireless/ath/ath11k/ahb.c
>> @@ -42,6 +42,9 @@ const struct ath11k_bus_params ath11k_ahb_hybrid_bus_params = {
>> .fixed_bdf_addr = false,
>> .fixed_mem_region = false,
>> .hybrid_bus_type = true,
>> + .static_window_map = true,
>> + .dp_window_idx = 1,
>> + .ce_window_idx = 2,
>> };
>
> Even if the values are zero, please initialise the new fields in every
> bus_params structure:
>
> ahb.c:31:static const struct ath11k_bus_params ath11k_ahb_bus_params = {
> pci.c:118:static const struct ath11k_bus_params ath11k_pci_bus_params = {
>
Makes sense, should I send another series addressing these?
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2022-04-27 5:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 9:40 [PATCH v4 00/12] add support for WCN6750 Manikanta Pubbisetty
2022-04-06 9:40 ` [PATCH v4 01/12] dt: bindings: net: add bindings of WCN6750 for ath11k Manikanta Pubbisetty
2022-04-06 15:08 ` Rob Herring
2022-04-07 5:21 ` Manikanta Pubbisetty
2022-04-27 5:13 ` Kalle Valo
2022-04-06 9:40 ` [PATCH v4 02/12] ath11k: Add HW params for WCN6750 Manikanta Pubbisetty
2022-04-27 5:21 ` Kalle Valo
2022-04-27 5:35 ` Manikanta Pubbisetty
2022-04-06 9:40 ` [PATCH v4 03/12] ath11k: Add bus " Manikanta Pubbisetty
2022-04-06 9:40 ` [PATCH v4 04/12] ath11k: Add register access logic " Manikanta Pubbisetty
2022-04-27 5:45 ` Kalle Valo
2022-04-27 5:53 ` Manikanta Pubbisetty [this message]
2022-04-29 8:57 ` Kalle Valo
2022-04-06 9:40 ` [PATCH v4 05/12] ath11k: Fetch device information via QMI " Manikanta Pubbisetty
2022-04-06 9:41 ` [PATCH v4 06/12] ath11k: Add QMI changes " Manikanta Pubbisetty
2022-04-06 9:41 ` [PATCH v4 07/12] ath11k: HAL changes to support WCN6750 Manikanta Pubbisetty
2022-04-06 9:41 ` [PATCH v4 08/12] ath11k: Datapath " Manikanta Pubbisetty
2022-04-06 9:41 ` [PATCH v4 09/12] ath11k: Do not put HW in DBS mode for WCN6750 Manikanta Pubbisetty
2022-04-27 7:26 ` Kalle Valo
2022-04-06 9:41 ` [PATCH v4 10/12] ath11k: WMI changes to support WCN6750 Manikanta Pubbisetty
2022-04-06 9:41 ` [PATCH v4 11/12] ath11k: Update WBM idle ring HP after FW mode on Manikanta Pubbisetty
2022-04-06 9:41 ` [PATCH v4 12/12] ath11k: Add support for WCN6750 device Manikanta Pubbisetty
2022-04-27 5:53 ` [PATCH v4 00/12] add support for WCN6750 Kalle Valo
2022-04-27 5:58 ` Manikanta Pubbisetty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a18a4d3-254b-727e-e96d-90deec61571c@quicinc.com \
--to=quic_mpubbise@quicinc.com \
--cc=ath11k@lists.infradead.org \
--cc=devicetree@vger.kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mka@chromium.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox