Re: [PATCH V2 4/4] ath11k: add HE support

[John Crispin <john@phrozen.org>]

Hi,

[...]
>
>               WIDTH_20_NOHT |   WIDTH_20    | WIDTH_40     | 
> WIDTH_80      | WIDTH_160        | WIDTH_80P80
>
> MODE_11G            11G       11NG_HT20       11NG_HT40 NA         
>          NA            NA
> MODE_11G_HE         11G       11AX_HE20_2G    11AX_HE40_2G 
> 11AX_HE80_2G         NA            NA
> MODE_11A            11A       11NA_HT20       11NA_HT40 NA          
>          NA            NA
> MODE_11A_VHT        11A       11AC_VHT20      11AC_VHT40 11AC_VHT80  
>          11AC_VHT160   11AC_VHT80_80
> MODE_11A_HE         11A       11AX_HE20       11AX_HE40 11AX_HE80   
>          11AX_HE160    11AX_HE80_80
>
> [...]
>
good idea !


>> +static enum wmi_phy_mode ath11k_mac_get_phymode_he(struct ath11k *ar,
>> +                           struct ieee80211_sta *sta)
>> +{
>> +    if (sta->bandwidth == IEEE80211_STA_RX_BW_160) {
>> +        if (sta->he_cap.he_cap_elem.phy_cap_info[0] &
>> + IEEE80211_HE_PHY_CAP0_CHANNEL_WIDTH_SET_160MHZ_IN_5G)
>> +            return MODE_11AX_HE160;
>> +        else if (sta->he_cap.he_cap_elem.phy_cap_info[0] &
>> + IEEE80211_HE_PHY_CAP0_CHANNEL_WIDTH_SET_80PLUS80_MHZ_IN_5G)
>> +            return MODE_11AX_HE80_80;
>> +        /* not sure if this is a valid case? */
>> +        return MODE_11AX_HE160;
>> +    }
>> +
>> +    if (sta->bandwidth == IEEE80211_STA_RX_BW_80)
>> +        return MODE_11AX_HE80;
>> +
>> +    if (sta->bandwidth == IEEE80211_STA_RX_BW_40)
>> +        return MODE_11AX_HE40;
>> +
>> +    if (sta->bandwidth == IEEE80211_STA_RX_BW_20)
>> +        return MODE_11AX_HE20;
>> +
>> +    return MODE_UNKNOWN;
>> +}
>> +
>
> I think this function also be removed if we have MODE table as 
> mentioned above.
>
> [...]
>
>> +static void ath11k_mac_copy_he_cap(struct ath11k_pdev_cap *cap,
>> +                   struct ieee80211_sband_iftype_data *data,
>> +                   int band)
>> +{
>> +    int i;
>> +
>> +    for (i = 0; i < 2; i++) {
>> +        struct ieee80211_sta_he_cap *he_cap = &data[i].he_cap;
>> +        struct ath11k_band_cap *band_cap = &cap->band[band];
>> +        struct ieee80211_he_cap_elem *he_cap_elem =
>> +                &he_cap->he_cap_elem;
>> +
>> +        he_cap->has_he = true;
>> +        memcpy(he_cap_elem->mac_cap_info, band_cap->he_cap_info,
>> +               sizeof(he_cap_elem->mac_cap_info));
>> +        memcpy(he_cap_elem->phy_cap_info, band_cap->he_cap_phy_info,
>> +               sizeof(he_cap_elem->phy_cap_info));
>> +
>> +        if (i) {
>> +            data[i].types_mask = BIT(NL80211_IFTYPE_STATION);
>> +            he_cap_elem->mac_cap_info[0] &=
>> +                ~IEEE80211_HE_MAC_CAP0_TWT_RES;
>> +            he_cap_elem->mac_cap_info[0] |=
>> +                IEEE80211_HE_MAC_CAP0_TWT_REQ;
>> +            /* TODO - add further differences between AP and STA */
>> +        } else {
>> +            data[i].types_mask = BIT(NL80211_IFTYPE_AP);
>> +        }
>>
> Hmmm.. If you are running loop to extract he_cap, he_cap_extn, how 
> will you extend HE support
> for other interface types (Mesh)?
>
I will make this future-proof

     John



_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k