ATH11K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: James Prestwood <prestwoj@gmail.com>
To: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>,
	Marcel Holtmann <marcel@holtmann.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wifi: ath11k: Optimize 6 GHz scan time
Date: Wed, 28 Dec 2022 13:22:14 -0800	[thread overview]
Message-ID: <378a1d63b3752ace7384c44d6f5184753fa7795d.camel@gmail.com> (raw)
In-Reply-To: <2861463e-a097-7efe-bc75-f13c8faf9547@quicinc.com>

Hi Manikanta,
> By the way, userspace itself selects the frequencies to scan, not the
> driver.
> 
> If we see the split scan implementation in cfg80211, this is the how
> it 
> is implemented. If NL80211_SCAN_FLAG_COLOCATED_6GHZ is set, it
> selects 
> all PSC channels and those non-PSC channels where RNR IE information
> is 
> found in the legacy scan results. If this flag is not set, all
> channels 
> in 6 GHz are included in the scan freq list. It is upto userspace to 
> decide what it wants.


This isn't your problem, but it needs to be said:

The nl80211 docs need and update to reflect this behavior (or remove
the PSC logic). IMO this is really weird that the kernel selects PSC's
based on the co-located flag. The docs don't describe this behavior and
the flag's name is misleading (its not
SCAN_FLAG_COLOCATED_AND_PSC_6GHZ) :)

If userspace doesn't specify a channel list then the kernel can do
whatever it wants, but otherwise it should stick to the requested
channels and scan only for co-located APs if the flag was set, not
PSC's too.

This basically adds ~3x the time to IWD's quick scan's for 6GHz capable
cards regardless if there are any co-located AP's. ugh.



-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

  reply	other threads:[~2022-12-28 21:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-20  4:38 [PATCH] wifi: ath11k: Optimize 6 GHz scan time Manikanta Pubbisetty
2022-12-20 13:06 ` Marcel Holtmann
2022-12-21  4:03   ` Manikanta Pubbisetty
2022-12-28 21:22     ` James Prestwood [this message]
2023-01-10  5:19       ` Manikanta Pubbisetty
2023-01-10 17:05         ` James Prestwood
2023-02-24 10:08           ` Manikanta Pubbisetty
2023-02-24 10:15             ` Johannes Berg
2023-02-27  4:23               ` Manikanta Pubbisetty
2023-02-27  8:25                 ` Peer, Ilan
2023-02-27 10:57                   ` Manikanta Pubbisetty
2023-03-09  9:43                 ` Manikanta Pubbisetty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=378a1d63b3752ace7384c44d6f5184753fa7795d.camel@gmail.com \
    --to=prestwoj@gmail.com \
    --cc=ath11k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=quic_mpubbise@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox