From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70A86CFD313 for ; Mon, 24 Nov 2025 15:52:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Subject:References:In-Reply-To:Message-Id:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/P3A8XqYfPOndlEJFspQX8roTam1zgUG+0GFJD35Qxs=; b=3SgS7FCXqiebdVYp8Bcjs+IA7j AGUYb/3l8qDwE/K6o2Yv0F45XcmbKJDozLHMoevxhgpHAJNiX+KAdN+XVkwz/GM5ogpJ+8ZXXGkSH zR2iw1rz7SpacfJF2OnruuMPm+9F1TrX+O99905UsTQq0v60d8wdQBVcLGrk7k6B7SHUnaK1o7Fs1 PUJLVun6qFK8lmAcHg1pKlCtsM7yxIHQ1DFrve2GKNT564ARLWeBj7bD2UJwk7vUo7uf5XEH0pBkk Udiz/XIeeDmxdWXdxMvPpoHTIAupjhbIKUZrY9IVlnq/5rBShIr374TSnBVTkbLs3V4taYQhg3mdf wF7HRH4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vNYrh-0000000Bx4R-2eoX; Mon, 24 Nov 2025 15:52:33 +0000 Received: from fout-b3-smtp.messagingengine.com ([202.12.124.146]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vNYre-0000000Bx3r-1iXV for ath11k@lists.infradead.org; Mon, 24 Nov 2025 15:52:33 +0000 Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfout.stl.internal (Postfix) with ESMTP id 9E1D11D00135; Mon, 24 Nov 2025 10:52:28 -0500 (EST) Received: from phl-imap-09 ([10.202.2.99]) by phl-compute-02.internal (MEProxy); Mon, 24 Nov 2025 10:52:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=squebb.ca; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1763999548; x=1764085948; bh=/P3A8XqYfPOndlEJFspQX8roTam1zgUG+0GFJD35Qxs=; b= AzqzzBAXA8nd1EXbhlP18z1STsQ3qFB10rarI1gmxLOe1hrZvKQuxrbaGJPdklAl lw4ARRnfuhwx1HBJubsJNodsqoBVqgRJVViy+OzN9VXrUoOZRsy/64IWk/2roxrZ ctPk8hyar8StLLI4WST2dx60vJATkbTN0dxUHOZFB8ukMHBBSs8CWmvvCAhZWu/q rDCmkq+VUUUzHCb5s9JuOPN/qFf2jj19dMYww39w4iXKgcqFcfG8NmFTEOWEbMiH uuBmWufSbdCYUw2QW0x6DA/7JDvWzAo2Zwyyih4QCv4EOlc3qOl9QuxMdj5SDj4A kpddWdv4SVOKeOKvvfwS5A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1763999548; x= 1764085948; bh=/P3A8XqYfPOndlEJFspQX8roTam1zgUG+0GFJD35Qxs=; b=V ZQi3v8seKXpXcl1DcLX1jvXIkHWOBST5TCPx0xckyoMixBcOBifaPu+dYAXrir10 7Pie2gLfHjBbW00YUIMhgedU2/73V4QSaa13PHWA3xY8GL3Wu1wn/6l8Tmcw+2aa RoGjZdnUfHtMChRbA+JP/qBgbq2j4lOBrfqW8Vuua7S0112sCWChf1uIaUtSIot8 cI1ovItYl2Us+FVzvkgRsocZ+JY+ouZdDEjqOjs1svpExvd8oyzGdaxK1FoXfgtS 1C6VMKx6c8BsVAqdlmbgRf6nx85X+3g+MS1Sz2m3uGCBfzjYDUUDEUDT1/eq0Cbb /msq4phIP9nQTRPJqCpHw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvfeeltdduucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddtnecuhfhrohhmpedfofgrrhhk ucfrvggrrhhsohhnfdcuoehmphgvrghrshhonhdqlhgvnhhovhhosehsqhhuvggssgdrtg grqeenucggtffrrghtthgvrhhnpefhhfffleeugeeivdelhfdvteejudekheetfffgueff leekudefteehieffuedtteenucffohhmrghinhepshhushgvrdgtohhmnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhpvggrrhhsohhnqdhl vghnohhvohesshhquhgvsggsrdgtrgdpnhgspghrtghpthhtohepgedpmhhouggvpehsmh htphhouhhtpdhrtghpthhtoheprghthhduudhksehlihhsthhsrdhinhhfrhgruggvrggu rdhorhhgpdhrtghpthhtohepjhgvfhhfrdhjohhhnhhsohhnsehoshhsrdhquhgrlhgtoh hmmhdrtghomhdprhgtphhtthhopehtihifrghisehsuhhsvgdruggvpdhrtghpthhtohep lhhinhhugidqfihirhgvlhgvshhssehvghgvrhdrkhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: ibe194615:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 17A1E3020061; Mon, 24 Nov 2025 10:52:28 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 X-ThreadId: Aw6v1Pokv1cZ Date: Mon, 24 Nov 2025 10:52:07 -0500 From: "Mark Pearson" To: "Takashi Iwai" Cc: "Jeff Johnson" , linux-wireless@vger.kernel.org, ath11k@lists.infradead.org Message-Id: <3b97881b-b21a-48ca-91f0-cbfac966ea76@app.fastmail.com> In-Reply-To: <878qfvqwdo.wl-tiwai@suse.de> References: <20251124134713.5819-1-tiwai@suse.de> <878qfvqwdo.wl-tiwai@suse.de> Subject: Re: [PATCH] wifi: ath11k: Add quirk entry for Thinkpad T14s Gen3 AMD Content-Type: text/plain Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251124_075230_524064_8A8C34B6 X-CRM114-Status: GOOD ( 29.92 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org On Mon, Nov 24, 2025, at 10:32 AM, Takashi Iwai wrote: > On Mon, 24 Nov 2025 16:13:05 +0100, > Mark Pearson wrote: >> >> Thanks Takashi-san, >> >> On Mon, Nov 24, 2025, at 8:47 AM, Takashi Iwai wrote: >> > The recent kernels showed a regression wrt suspend/resume on Lenovo >> > Thinkpad T14s Gen 3 AMD model; it fails to reconnect on resume after a >> > long time sleep. The only workaround was to unload/reload the driver >> > (or reboot). >> > >> > It seems that this model also requires the similar quirk with >> > ATH11K_PM_WOW which has been done for other Thinkpad models. >> > >> > Link: https://bugzilla.suse.com/show_bug.cgi?id=1254181 >> > Signed-off-by: Takashi Iwai >> > --- >> > >> > I'm not sure whether this model has another DMI entry, so put Mark to >> > Cc. >> > >> > Also, I wonder which Thinkpad models are rather the ones that should >> > *not* take the quirk. Since mine is Gen 3 and I already see Gen 2 >> > entries, which else remaining...? >> > >> >> It should only apply to models with the ath11k modem - but it looks like Gen 2 up to Gen 6....which is quite a lot. I don't know if all of those are impacted. >> I think we'll have to do more testing and get feedback from the FW team, which will take a bit I'm afraid. I'll look into it. > > I see, thanks for confirmation! > >> > >> > drivers/net/wireless/ath/ath11k/core.c | 7 +++++++ >> > 1 file changed, 7 insertions(+) >> > >> > diff --git a/drivers/net/wireless/ath/ath11k/core.c >> > b/drivers/net/wireless/ath/ath11k/core.c >> > index 812686173ac8..3aa78a39394b 100644 >> > --- a/drivers/net/wireless/ath/ath11k/core.c >> > +++ b/drivers/net/wireless/ath/ath11k/core.c >> > @@ -924,6 +924,13 @@ static const struct dmi_system_id >> > ath11k_pm_quirk_table[] = { >> > DMI_MATCH(DMI_PRODUCT_NAME, "21J4"), >> > }, >> > }, >> > + { >> > + .driver_data = (void *)ATH11K_PM_WOW, >> > + .matches = { /* T14s G3 AMD */ >> > + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), >> > + DMI_MATCH(DMI_PRODUCT_NAME, "21CR"), >> > + }, >> > + }, >> > { >> > .driver_data = (void *)ATH11K_PM_WOW, >> > .matches = { /* T14 G4 AMD #1 */ >> > -- >> > 2.52.0 >> >> I think you need to add the "21CQ" Product Name for this platform too (every model has two IDs depending on where in the world it is deployed) >> >> Unfortunately my T14s G3 AMD seems to be dead :( I can't test and confirm directly. > > OK, I can resubmit with 21CQ entry later. > > Also, maybe it'd be worth for adding a module option to specify / > override the quirk, so that one can test without recompiling the > kernel? > Yeah - that could be useful so users can confirm if they need the quirk too (especially if platforms outside of the Linux program are impacted). It gets my vote :) Mark