ATH11K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: John Crispin <john@phrozen.org>
Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org,
	Shashidhar Lakkavalli <slakkavalli@datto.com>
Subject: Re: [PATCH V2 4/6] mac80211: HE: add Spatial Reuse IE parsing support
Date: Fri, 14 Jun 2019 14:34:15 +0200	[thread overview]
Message-ID: <3ef2937994bb0c4c9076b153deaf3c42e2e9a75f.camel@sipsolutions.net> (raw)
In-Reply-To: <20190528114952.838-5-john@phrozen.org>

> +/*
> + * ieee80211_he_spr_size - calculate 802.11ax HE Spatial Reuse IE size
> + * @he_spr_ie: byte data of the He Spatial Reuse IE, stating from the the byte
> + *	after the ext ID byte. It is assumed that he_spr_ie has at least
> + *	sizeof(struct ieee80211_he_spr) bytes, checked already in
> + *	ieee802_11_parse_elems_crc()

That reference to mac80211 isn't really quite appropriate here - should
say something like "the caller must have validated this". This is a
lower layer usable by non-mac80211 as well.

johannes


_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

  reply	other threads:[~2019-06-14 12:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-28 11:49 [PATCH V2 0/6] mac80211: HE: add TWT and SPR/OBSSPD support John Crispin
2019-05-28 11:49 ` [PATCH V2 1/6] mac80211: dynamically enable the TWT requester support on STA interfaces John Crispin
2019-05-28 11:49 ` [PATCH V2 2/6] mac80211: allow turning TWT responder support on and off via netlink John Crispin
2019-05-28 11:49 ` [PATCH V2 3/6] ath11k: add TWT support John Crispin
2019-05-28 11:49 ` [PATCH V2 4/6] mac80211: HE: add Spatial Reuse IE parsing support John Crispin
2019-06-14 12:34   ` Johannes Berg [this message]
2019-05-28 11:49 ` [PATCH V2 5/6] mac80211: allow setting spatial reuse parameters from bss_conf John Crispin
2019-05-28 11:49 ` [PATCH V2 6/6] ath11k: add spatial reuse support John Crispin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ef2937994bb0c4c9076b153deaf3c42e2e9a75f.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ath11k@lists.infradead.org \
    --cc=john@phrozen.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=slakkavalli@datto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox