From: Sriram R <srirrama@codeaurora.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: ath11k@lists.infradead.org
Subject: Re: [PATCH] ath11k: Add probe response throttling logic
Date: Tue, 16 Jul 2019 20:13:51 +0530 [thread overview]
Message-ID: <4d57bd235631cb7952cfaec9c6bdedb4@codeaurora.org> (raw)
In-Reply-To: <87muhe89ex.fsf@kamboji.qca.qualcomm.com>
On 2019-07-16 17:43, Kalle Valo wrote:
> Sriram R <srirrama@codeaurora.org> writes:
>
>> Drop probe response packets when the pending management tx
>> count has reached a certain threshold, so as to prioritize
>> other mgmt packets like auth and assoc to be sent on time
>> for establishing successful connections.
>> This might be required in dense networks, multi-vap scenarios
>> or due to emulated probe requests (DoS attack),
>> which could lead to association failures due to failure to
>> send auth/assoc packets as high probe response traffic occupies the
>> limited target mgmt transmit queue.
>> Currently the threshold is set to 3/4th of the target management
>> tx queue.
>>
>> Signed-off-by: Sriram R <srirrama@codeaurora.org>
>
> [...]
>
>> --- a/drivers/net/wireless/ath/ath11k/wmi.c
>> +++ b/drivers/net/wireless/ath/ath11k/wmi.c
>> @@ -3366,6 +3366,9 @@ static int wmi_process_mgmt_tx_comp(struct
>> ath11k *ar, u32 desc_id,
>>
>> ieee80211_tx_status_irqsafe(ar->hw, msdu);
>>
>> + WARN_ON(atomic_read(&ar->num_pending_mgmt_tx) == 0);
>
> In the pending branch I changed this to WARN_ON_ONCE() so that we don't
> excessively spam the logs:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending-ath11k&id=02d5ce6ef5feff4bbc80afd800586bd15879b714
Fine Kalle. Thanks for making this change.
Regards,
Sriram.R
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2019-07-16 14:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 0:35 [PATCH] ath11k: Add probe response throttling logic Sriram R
2019-07-16 12:13 ` Kalle Valo
2019-07-16 14:43 ` Sriram R [this message]
2019-07-17 12:21 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d57bd235631cb7952cfaec9c6bdedb4@codeaurora.org \
--to=srirrama@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=kvalo@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox