From: John Crispin <john@phrozen.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: ath11k@lists.infradead.org,
Shashidhar Lakkavalli <slakkavalli@datto.com>
Subject: Re: [PATCH V4 1/5] ath11k: move phymode selection from function to array lookup
Date: Wed, 15 May 2019 11:39:22 +0200 [thread overview]
Message-ID: <4f655243-44f2-1094-6a0f-e1916392f2ae@phrozen.org> (raw)
In-Reply-To: <87tvdyig5t.fsf@kamboji.qca.qualcomm.com>
On 13/05/2019 16:26, Kalle Valo wrote:
>> @@ -3889,7 +3872,12 @@ ath11k_mac_vdev_start_restart(struct ath11k_vif *arvif,
>> arg.channel.freq = chandef->chan->center_freq;
>> arg.channel.band_center_freq1 = chandef->center_freq1;
>> arg.channel.band_center_freq2 = chandef->center_freq2;
>> - arg.channel.mode = chan_to_phymode(chandef);
>> + arg.channel.mode =
>> + ath11k_phymodes[chandef->chan->band][he_support][chandef->width];
>> + if (arg.channel.mode == MODE_11G &&
>> + chandef->chan->flags & IEEE80211_CHAN_NO_OFDM)
>> + arg.channel.mode = MODE_11B;
>> + WARN_ON(arg.channel.mode == MODE_UNKNOWN);
> What happens when mode is MODE_UNKNOWN? Should we assign some default
> value after the warning message?
the driver uses that enum value at various places and it seems to be a
valid wmi ID so i guess its better to let it blow up upon a bad
configuration than silently falling back to a possibly unexpected behaviour
John
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2019-05-15 9:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 20:15 [PATCH V4 0/5] ath11k: add HE support John Crispin
2019-05-09 20:15 ` [PATCH V4 1/5] ath11k: move phymode selection from function to array lookup John Crispin
2019-05-13 14:26 ` Kalle Valo
2019-05-15 9:39 ` John Crispin [this message]
2019-05-13 17:07 ` Kalle Valo
2019-05-09 20:15 ` [PATCH V4 2/5] ath11k: add HE handling to the debug code John Crispin
2019-05-09 20:15 ` [PATCH V4 3/5] ath11k: extend reading of FW capabilities John Crispin
2019-05-09 20:15 ` [PATCH V4 4/5] ath11k: handle rx status for HE frames John Crispin
2019-05-13 14:28 ` Kalle Valo
2019-05-09 20:15 ` [PATCH V4 5/5] ath11k: add HE support John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f655243-44f2-1094-6a0f-e1916392f2ae@phrozen.org \
--to=john@phrozen.org \
--cc=ath11k@lists.infradead.org \
--cc=kvalo@codeaurora.org \
--cc=slakkavalli@datto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox