From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from m43-7.mailgun.net ([69.72.43.7]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJ923-0001HW-TI for ath11k@lists.infradead.org; Fri, 18 Sep 2020 05:34:05 +0000 MIME-Version: 1.0 Date: Fri, 18 Sep 2020 11:04:01 +0530 From: vnaralas@codeaurora.org Subject: Re: [PATCHv2] ath11k: add raw mode and software crypto support In-Reply-To: <871rj0h1oh.fsf@codeaurora.org> References: <010101746c6a54fa-91406158-3f0a-4f10-8328-a7f560dd3feb-000000@us-west-2.amazonses.com> <871rj0h1oh.fsf@codeaurora.org> Message-ID: <51bbe58e337427f5238a757d8c2c6ee1@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath11k" Errors-To: ath11k-bounces+kvalo=adurom.com@lists.infradead.org To: Kalle Valo Cc: Manikanta Pubbisetty , linux-wireless@vger.kernel.org, ath11k@lists.infradead.org On 2020-09-17 20:48, Kalle Valo wrote: > Venkateswara Naralasetty writes: > >> Adding raw mode tx/rx support. Also, adding support >> for software crypto which depends on raw mode. >> >> To enable raw mode tx/rx: >> insmod ath11k.ko frame_mode=0 >> >> To enable software crypto: >> insmod ath11k.ko crypto_mode=1 >> >> These modes could be helpful in debugging crypto related issues. >> >> Tested-on: IPQ8074 WLAN.HK.2.1.0.1-01228-QCAHKSWPL_SILICONZ-1 >> >> Signed-off-by: Manikanta Pubbisetty >> Signed-off-by: Venkateswara Naralasetty > > [...] > >> --- a/drivers/net/wireless/ath/ath11k/wmi.c >> +++ b/drivers/net/wireless/ath/ath11k/wmi.c >> @@ -3366,6 +3366,10 @@ int ath11k_wmi_cmd_init(struct ath11k_base *ab) >> config.rx_timeout_pri[2] = TARGET_RX_TIMEOUT_LO_PRI; >> config.rx_timeout_pri[3] = TARGET_RX_TIMEOUT_HI_PRI; >> config.rx_decap_mode = TARGET_DECAP_MODE_NATIVE_WIFI; >> + >> + if (test_bit(ATH11K_FLAG_RAW_MODE, &ab->dev_flags)) >> + config.rx_decap_mode = TARGET_DECAP_MODE_RAW; > > Did you test this at all? Because to me it looks like in > ath11k_init_wmi_config_ipq8074() this is overwritten with: > > config->rx_decap_mode = TARGET_DECAP_MODE_NATIVE_WIFI; > > So I can't see how this would even work. I noticed this while I was > cleaning up ath11k_wmi_cmd_init(). I'll send a patch soon, please test > that and let me know if it works. My bad it seems my tree is bit older, sorry for the confusion. Also I noticed, .wmi_init_config of ipq8074_ops is registered with " ath11k_init_wmi_config_qca6390()" Is that correct? If that is correct, then I don't see ath11k_init_wmi_config_ipq8074() is called from any other place. I will send one patch to fix this issue. Please correct me if I am wrong. -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k