From: Krzysztof Kozlowski <krzk@kernel.org>
To: george.moussalem@outlook.com,
Johannes Berg <johannes@sipsolutions.net>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jeff Johnson <jjohnson@kernel.org>
Cc: linux-wireless@vger.kernel.org, devicetree@vger.kernel.org,
ath11k@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] dt: bindings: net: add bindings for QCN6122
Date: Wed, 29 Oct 2025 15:42:23 +0100 [thread overview]
Message-ID: <52a0d7f1-e342-46a6-86e7-9852ac2f2eba@kernel.org> (raw)
In-Reply-To: <3dc712ae-b51f-4142-bbab-1eadbc27e60a@kernel.org>
On 29/10/2025 15:32, Krzysztof Kozlowski wrote:
>> interrupt-names:
>> @@ -87,6 +88,14 @@ properties:
>> items:
>> - const: wlan-smp2p-out
>>
>> + qcom,userpd:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + enum: [2, 3]
>> + description: instance ID of user PD (protection domain) in multi-PD
>> + architectures to distinguish between multiple instances
>> + of the same wifi chip used by QMI in its interface with
>> + the firmware running on Q6.
>
> Broken indentation. It is supposed to be two spaces. Look at this file -
> why are you doing this completely different?
>
> Anyway, please do not come with 2nd or 3rd property for this. We already
> have such somewhere.
And reading the driver code, this is instance ID, so not really suitable
here. Sorry, such are not allowed. See writing bindings or my last OSSE
slides.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-29 14:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 14:26 [PATCH 0/6] wifi: ath11k: Add support for QCN6122 George Moussalem via B4 Relay
2025-10-29 14:26 ` [PATCH 1/6] dt: bindings: net: add bindings " George Moussalem via B4 Relay
2025-10-29 14:32 ` Krzysztof Kozlowski
2025-10-29 14:42 ` Krzysztof Kozlowski [this message]
2025-10-29 16:12 ` George Moussalem
2025-10-30 5:47 ` Krzysztof Kozlowski
2025-10-29 14:26 ` [PATCH 2/6] wifi: ath11k: add hw params " George Moussalem via B4 Relay
2025-10-29 14:26 ` [PATCH 3/6] wifi: ath11k: add hw ring mask " George Moussalem via B4 Relay
2025-10-29 14:33 ` Krzysztof Kozlowski
2025-10-29 14:26 ` [PATCH 4/6] wifi: ath11k: update hif and pci ops " George Moussalem via B4 Relay
2025-10-29 14:26 ` [PATCH 5/6] wifi: ath11k: add multipd support " George Moussalem via B4 Relay
2025-10-29 14:43 ` Krzysztof Kozlowski
2025-10-29 17:41 ` George Moussalem
2025-10-29 14:26 ` [PATCH 6/6] wifi: ath11k: add QCN6122 device support George Moussalem via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52a0d7f1-e342-46a6-86e7-9852ac2f2eba@kernel.org \
--to=krzk@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=george.moussalem@outlook.com \
--cc=jjohnson@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox