From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5EFB5D591AD for ; Mon, 18 Nov 2024 18:09:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:Cc:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wR2vAxb4KjC7bChWhYgHEm7VYOkoUSKJ2zrGmmUQgeU=; b=eHT4v9GhkwSNwnLyQi20sJd3Mh 5yXEZ1Wp7U8vrwEq0OshXJc3aCNF5f2qJc/bj245iOHBDYjVb8nni/xNpb42ckjSlPKfeHRYff3eu zNYgdW32ysLpqxUyh3BHwnXJwdZYtwBX2r3DlGHzQpPuj+Fk+VEXGYO2wpuwLXra/36O/OYmiIR2X XeYy76uIcaeL4IrjBLEztZ6sLOohviwRxjXgY9i3iAZ8YFb8VUkglBTx9e09yAYFQtAIYfMcJ5fZN i336w6Oqn9tnH9q1xxM7++npY5SFMroMwDmxBas/NLcbZHwRgNcf00CD3OOBFmm+uDvX/ObvSUMEE wTitgzIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tD6Bf-0000000AIP5-42IO; Mon, 18 Nov 2024 18:09:23 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tD6Bd-0000000AINi-1Fye; Mon, 18 Nov 2024 18:09:22 +0000 Received: from [192.168.35.166] (c-73-118-245-227.hsd1.wa.comcast.net [73.118.245.227]) by linux.microsoft.com (Postfix) with ESMTPSA id B3D1220BEBD0; Mon, 18 Nov 2024 10:09:17 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B3D1220BEBD0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1731953360; bh=wR2vAxb4KjC7bChWhYgHEm7VYOkoUSKJ2zrGmmUQgeU=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=QcXvfQn32bbEJk/CliGqPjJlSoPmzpqy39Cb7yWbUp/UMAorBMUaWUr/NKZ9e69DC EuA6BiEwniO9Hz9jAZdoaPATG/Z4etAtwQMMCiIdSJ0wltRFnatVskzJPAClKWSWJ2 IoOFaRlq/Uc2MlJVJm0M77F7OwMbRuycEwh39LjI= Message-ID: <52cc0733-49fc-4452-99c6-8c18bf20dde7@linux.microsoft.com> Date: Mon, 18 Nov 2024 10:09:17 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: eahariha@linux.microsoft.com, James.Bottomley@HansenPartnership.com, Julia.Lawall@inria.fr, agordeev@linux.ibm.com, airlied@gmail.com, akpm@linux-foundation.org, andrew+netdev@lunn.ch, anna-maria@linutronix.de, ath11k@lists.infradead.org, axboe@kernel.dk, bcm-kernel-feedback-list@broadcom.com, borntraeger@linux.ibm.com, catalin.marinas@arm.com, ceph-devel@vger.kernel.org, christian.gmeiner@gmail.com, christophe.leroy@csgroup.eu, cocci@inria.fr, coreteam@netfilter.org, daniel@zonque.org, davem@davemloft.net, dick.kennedy@broadcom.com, dri-devel@lists.freedesktop.org, edumazet@google.com, etnaviv@lists.freedesktop.org, florian.fainelli@broadcom.com, gor@linux.ibm.com, gregkh@linuxfoundation.org, haojian.zhuang@gmail.com, hca@linux.ibm.com, horms@kernel.org, idryomov@gmail.com, intel-xe@lists.freedesktop.org, james.smart@broadcom.com, jeroendb@google.com, jikos@kernel.org, jinpu.wang@cloud.ionos.com, jjohnson@kernel.org, joe.lawrence@redhat.com, johan.hedberg@gmail.com, jpoimboe@kernel.org, kadlec@netfilter.org, kuba@kernel.org, kvalo@kernel.org, l.stach@pengutronix.de, linux+etnaviv@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rpi-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sound@vger.kernel.org, linux-staging@lists.linux.dev, linux-wireless@vger.kernel.org, linux@armlinux.org.uk, linuxppc-dev@lists.ozlabs.org, live-patching@vger.kernel.org, louis.peens@corigine.com, lucas.demarchi@intel.com, luiz.dentz@gmail.com, maarten.lankhorst@linux.intel.com, maddy@linux.ibm.com, marcel@holtmann.org, martin.petersen@oracle.com, mbenes@suse.cz, mpe@ellerman.id.au, mripard@kernel.org, naveen@kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, nicolas.palix@imag.fr, npiggin@gmail.com, obitton@habana.ai, ogabbay@kernel.org, oss-drivers@corigine.com, pabeni@redhat.com, pablo@netfilter.org, perex@perex.cz, pkaligineedi@google.com, pmladek@suse.com, rjui@broadcom.com, robert.jarzmik@free.fr, rodrigo.vivi@intel.com, roger.pau@citrix.com, sbranden@broadcom.com, shailend@google.com, simona@ffwll.ch, svens@linux.ibm.com, thomas.hellstrom@linux.intel.com, tiwai@suse.com, tzimmermann@suse.de, xen-devel@lists.xenproject.org, xiubli@redhat.com Subject: Re: [PATCH v2 02/21] coccinelle: misc: Add secs_to_jiffies script To: Christophe JAILLET References: <20241115-converge-secs-to-jiffies-v2-2-911fb7595e79@linux.microsoft.com> <20241116060541.5798-1-christophe.jaillet@wanadoo.fr> From: Easwar Hariharan Content-Language: en-US In-Reply-To: <20241116060541.5798-1-christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241118_100921_381437_5A99386B X-CRM114-Status: GOOD ( 12.19 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org On 11/15/2024 10:05 PM, Christophe JAILLET wrote: > Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : >> Suggested-by: Anna-Maria Behnsen >> Signed-off-by: Easwar Hariharan >> --- >> scripts/coccinelle/misc/secs_to_jiffies.cocci | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> >> diff --git a/scripts/coccinelle/misc/secs_to_jiffies.cocci b/scripts/coccinelle/misc/secs_to_jiffies.cocci >> new file mode 100644 >> index 0000000000000000000000000000000000000000..af762b1c0aac8f044f21150bfaafd9efc834ee87 >> --- /dev/null >> +++ b/scripts/coccinelle/misc/secs_to_jiffies.cocci >> @@ -0,0 +1,21 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +/// >> +/// Find usages of: >> +/// - msecs_to_jiffies(value*1000) >> +/// - msecs_to_jiffies(value*MSEC_PER_SEC) >> +/// >> +// Confidence: High >> +// Copyright: (C) 2024 Easwar Hariharan Microsoft >> +// >> +// Keywords: secs, seconds, jiffies >> +// >> + >> +@@ constant C; @@ >> + >> +- msecs_to_jiffies(C * 1000) >> ++ secs_to_jiffies(C) >> + >> +@@ constant C; @@ >> + >> +- msecs_to_jiffies(C * MSEC_PER_SEC) >> ++ secs_to_jiffies(C) >> > Hi, > > @@ constant C =~ "000"; @@ > > * msecs_to_jiffies(C) > > also spots things like msecs_to_jiffies(1000) > > I'm not sure that coccinelle is enable to capture part of the regex to automate the removal of the 000 when converting from ms to s. > > Just my 2c, > > CJ Thank you, I'll try that rule for the later parts. Thank you all for helping with writing Coccinelle rules, I'm not familiar with metaprogramming in general and Coccinelle in particular, so these are super helpful. - Easwar