From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from z5.mailgun.us ([104.130.96.5]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kez5B-0005FL-Qy for ath11k@lists.infradead.org; Tue, 17 Nov 2020 11:23:35 +0000 MIME-Version: 1.0 Date: Tue, 17 Nov 2020 16:53:31 +0530 From: vnaralas@codeaurora.org Subject: Re: [PATCHv2 1/2] nl80211: vendor-cmd: qca: add command for ap power save In-Reply-To: <60c779b7c17b8ea40c2bba08d8fca98e83581580.camel@sipsolutions.net> References: <1598257589-19091-1-git-send-email-vnaralas@codeaurora.org> <4b4a0d79a243c1c3b8044730da0493c96ba294bf.camel@sipsolutions.net> <871rilf2th.fsf@codeaurora.org> <87eelr1oq9.fsf@codeaurora.org> <81ced18ac5b87a17cf31797cf91669bc@codeaurora.org> <87sg9rtugu.fsf@codeaurora.org> <60c779b7c17b8ea40c2bba08d8fca98e83581580.camel@sipsolutions.net> Message-ID: <83bafd0a110106096110afd24b8e1304@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath11k" Errors-To: ath11k-bounces+kvalo=adurom.com@lists.infradead.org To: Johannes Berg Cc: Arend Van Spriel , linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, Kalle Valo On 2020-11-06 16:11, Johannes Berg wrote: > On Mon, 2020-11-02 at 21:44 +0200, Kalle Valo wrote: >> vnaralas@codeaurora.org writes: >> >> > On 2020-10-22 13:30, Arend Van Spriel wrote: >> > > On 10/21/2020 7:19 PM, Kalle Valo wrote: >> > > > vnaralas@codeaurora.org writes: >> > > > >> > > > > On 2020-09-29 13:10, Kalle Valo wrote: >> > > > > > Johannes Berg writes: >> > > > > > >> > > > > > > On Mon, 2020-08-24 at 13:56 +0530, Venkateswara Naralasetty wrote: >> > > > > > > > AP power save feature is to save power in AP mode, where AP goes >> > > > > > > > to power save mode when no stations associate to it and comes out >> > > > > > > > of power save when any station associate to AP. >> > > > > > > >> > > > > > > Why do you think this requires a vendor command? I mean, that seems >> > > > > > > like >> > > > > > > fairly reasonable - even by default - behaviour? >> > > > > > >> > > > > > I have not studied the details, but doesn't AP power save break >> > > > > > normal >> > > > > > functionality? For example, I would guess probe requests from >> > > > > > clients >> > > > > > would be lost. So there's a major drawback when enabling this, >> > > > > > right? >> > > > > >> > > > > This AP power save feature will not break any functionality, Since >> > > > > one >> > > > > chain is always active and all other chains will be disabled when >> > > > > this >> > > > > feature is enabled. AP can still be able to beacon and receive probe >> > > > > request from the clients. The only drawback is reduced network range >> > > > > when this feature is enabled. Hence, we don't want to enable it by >> > > > > default. >> > > > >> > > > Yeah, we really would not want to enable that by default. But what >> > > > should be the path forward, a vendor command or a proper nl80211 >> > > > command? Any opinions? >> > > >> > > I would go for a proper nl80211 command or just add an attribute for >> > > use in NL80211_CMD_START_AP or deal with NL80211_CMD_SET_POWERSAVE >> > > when operating in AP mode. >> > > >> > Sure, I will go with the existing NL80211_CMD_SET_POWERSAVE and I will >> > send next version. >> >> Better to wait first so that we have concensus on this. And need to >> check if NL80211_CMD_SET_POWERSAVE is even suitable for AP mode. > > I suspect that SET_POWERSAVE might be confusing. > > Perhaps just with an attribute used in START_AP (and CHANGE_BEACON if > needed) would be sufficient? Actually this ap power save configuration is applicable for per pdev. So, I don't think we can use START AP command here. I would prefer to go with a new NL80211 command. Please share your thoughts on this. > > johannes -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k