From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hctdp-0005Yu-UL for ath11k@lists.infradead.org; Mon, 17 Jun 2019 15:33:55 +0000 From: Kalle Valo Subject: Re: [PATCH V2] ath11k: Fix Rx signal strength reporting References: <1560399999-14062-1-git-send-email-vthiagar@codeaurora.org> <20190617153121.973E560F3D@smtp.codeaurora.org> Date: Mon, 17 Jun 2019 18:33:50 +0300 In-Reply-To: <20190617153121.973E560F3D@smtp.codeaurora.org> (Kalle Valo's message of "Mon, 17 Jun 2019 15:31:21 +0000 (UTC)") Message-ID: <8736k8b50h.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath11k" Errors-To: ath11k-bounces+kvalo=adurom.com@lists.infradead.org To: Vasanthakumar Thiagarajan Cc: ath11k@lists.infradead.org Kalle Valo writes: > Vasanthakumar Thiagarajan wrote: > >> Since rssi in not reported in MSDU_START tlv, current signal strength >> reporting is always wrong. Correct rssi is reported in PPDU_END tlv. >> Enable PPDU_END, PPDU_END_STATUS_DONE and MPDU_START tlv reporting in >> monitor status by default. Pass the sta's Rx signal strength to mac80211 >> in sta_statistics() ops. This patch also makes sure the default rx filter >> is always enabled whenever there is a call to reset the filter (from >> extd_rx_stats debugfs and config_filter path). Since some of the rx_stats >> are enabled by default, make memory allocation of arsta->rx_stats unconditional. >> >> Signed-off-by: Vasanthakumar Thiagarajan >> Signed-off-by: Kalle Valo > > This had a conflict and 3-way merge didn't work as the SHA ids were not valid. > Please always try to use ath11k-bringup branch as the baseline (and no extra > patches), that helps my conflict resolution a lot. > > Applied patch drivers/net/wireless/ath/ath11k/core.h cleanly. > Applied patch drivers/net/wireless/ath/ath11k/debug.c cleanly. > Applied patch drivers/net/wireless/ath/ath11k/dp_rx.c cleanly. > Applying patch drivers/net/wireless/ath/ath11k/dp_tx.c with 1 reject... > Rejected hunk #1. > Applied patch drivers/net/wireless/ath/ath11k/hal_rx.c cleanly. > Applied patch drivers/net/wireless/ath/ath11k/mac.c cleanly. > Applied patch drivers/net/wireless/ath/ath11k/mac.h cleanly. > Patch failed at 0001 ath11k: Fix Rx signal strength reporting > > I fixed the conflict in dp_tx.c, that was pretty easy. Also I fixed one > compilation error due to dp function renames. Also I removed > ath11k_dp_rx_h_msdu_start_rssi() as GCC warned that it's unused. Oops, I forgot to add the link to the pending branch: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending-ath11k&id=b36e8ecd8b4e7000a2844db022601890e0b1b39d Please check carefully my changes. Oh, and I also added mac_ prefix to mon_status_filter_default. -- Kalle Valo _______________________________________________ ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k