From: Kalle Valo <kvalo@kernel.org>
To: Wen Gong <quic_wgong@quicinc.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless <linux-wireless@vger.kernel.org>,
<ath11k@lists.infradead.org>
Subject: Re: [PATCH] wifi: mac80211: RCU-ify link STA pointers
Date: Mon, 12 Sep 2022 14:05:19 +0300 [thread overview]
Message-ID: <875yhs97kg.fsf@kernel.org> (raw)
In-Reply-To: <7199bd7d-b45c-5c72-576e-363ad37cce82@quicinc.com> (Wen Gong's message of "Mon, 12 Sep 2022 18:55:04 +0800")
Wen Gong <quic_wgong@quicinc.com> writes:
> On 9/12/2022 6:49 PM, Kalle Valo wrote:
>> Wen Gong <quic_wgong@quicinc.com> writes:
>>
>>> Hi Johannes,
>>>
>>> Currently for MLO test, the others links's rx_nss of struct
>>> ieee80211_link_sta is still value 0 in ieee80211_set_associated(),
>>> becaue they are not pass into ieee80211_sta_set_rx_nss() in
>>> mac80211 except the deflink which means the primary link.
>>> This lead driver get nss = 0 for other links. Will you fix it
>>> or is it design by default?
>>>
>>> Only primary link has valid rx_nss value which is not 0 by below call stack.
>>> ieee80211_assoc_success()->
>>> rate_control_rate_init(sta);
>>>
>>> commit:c71420db653aba30a234d1e4cf86dde376e604fa
>>> wifi: mac80211: RCU-ify link STA pointers
>> Strange format and s-o-b missing. Was this meant as an RFC patch?
>
> This is not a patch for review, it is to ask some question about the patch
>
> "wifi: mac80211: RCU-ify link STA pointers" which is already upstream.
Then you should not add "[PATCH]" in the subject. The string "[PATCH]"
is supposed to inform that the email contains a patch which should be
applied.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2022-09-12 11:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 9:36 [PATCH] wifi: mac80211: RCU-ify link STA pointers Wen Gong
2022-09-12 10:49 ` Kalle Valo
2022-09-12 10:55 ` Wen Gong
2022-09-12 11:05 ` Kalle Valo [this message]
2022-09-13 4:29 ` Wen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yhs97kg.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_wgong@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox