ATH11K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: John Crispin <john@phrozen.org>
Cc: ath11k@lists.infradead.org,
	Shashidhar Lakkavalli <slakkavalli@datto.com>
Subject: Re: [PATCH 1/2] ath11k: ignore event 0x6017
Date: Wed, 31 Jul 2019 17:55:53 +0300	[thread overview]
Message-ID: <878ssep81y.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <877e8f371b.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Thu, 18 Jul 2019 14:40:16 +0300")

Kalle Valo <kvalo@codeaurora.org> writes:

> John Crispin <john@phrozen.org> writes:
>
>> Everytime a new peer gets associated, we see the following message in the log
>> - ath11k c000000.wifi1: Unknown eventid: 0x6017
>> Ignore this event for now. We probably need to handle the event properly when
>> we add OMI support.
>>
>> Signed-off-by: Shashidhar Lakkavalli <slakkavalli@datto.com>
>> Signed-off-by: John Crispin <john@phrozen.org>
>> ---
>>  drivers/net/wireless/ath/ath11k/wmi.c |  1 +
>>  drivers/net/wireless/ath/ath11k/wmi.h | 13 ++++++++++++-
>>  2 files changed, 13 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c
>> index cba9f3a9ebfd..4ec6f5d50459 100644
>> --- a/drivers/net/wireless/ath/ath11k/wmi.c
>> +++ b/drivers/net/wireless/ath/ath11k/wmi.c
>> @@ -5591,6 +5591,7 @@ static void ath11k_wmi_tlv_op_rx(struct ath11k_base *ab, struct sk_buff *skb)
>>  	/* add Unsupported events here */
>>  	case WMI_TBTTOFFSET_EXT_UPDATE_EVENTID:
>>  	case WMI_VDEV_DELETE_RESP_EVENTID:
>> +	case WMI_PEER_OPER_MODE_CHANGE_EVENTID:
>>  		ath11k_dbg(ab, ATH11K_DBG_WMI,
>>  			   "ignoring unsupported event 0x%x\n", id);
>>  		break;
>> diff --git a/drivers/net/wireless/ath/ath11k/wmi.h b/drivers/net/wireless/ath/ath11k/wmi.h
>> index 7d933eafd3cd..364b44080493 100644
>> --- a/drivers/net/wireless/ath/ath11k/wmi.h
>> +++ b/drivers/net/wireless/ath/ath11k/wmi.h
>> @@ -288,7 +288,6 @@ enum wmi_tlv_cmd_id {
>>  	WMI_PEER_REORDER_QUEUE_REMOVE_CMDID,
>>  	WMI_PEER_SET_RX_BLOCKSIZE_CMDID,
>>  	WMI_PEER_ANTDIV_INFO_REQ_CMDID,
>> -	WMI_PEER_OPER_MODE_CHANGE_EVENTID,
>>  	WMI_BCN_TX_CMDID = WMI_TLV_CMD(WMI_GRP_MGMT),
>>  	WMI_PDEV_SEND_BCN_CMDID,
>>  	WMI_BCN_TMPL_CMDID,
>> @@ -586,6 +585,18 @@ enum wmi_tlv_event_id {
>>  	WMI_WDS_PEER_EVENTID,
>>  	WMI_PEER_STA_PS_STATECHG_EVENTID,
>>  	WMI_PEER_ANTDIV_INFO_EVENTID,
>> +	WMI_PEER_RESERVED0_EVENTID,
>> +	WMI_PEER_RESERVED1_EVENTID,
>> +	WMI_PEER_RESERVED2_EVENTID,
>> +	WMI_PEER_RESERVED3_EVENTID,
>> +	WMI_PEER_RESERVED4_EVENTID,
>> +	WMI_PEER_RESERVED5_EVENTID,
>> +	WMI_PEER_RESERVED6_EVENTID,
>> +	WMI_PEER_RESERVED7_EVENTID,
>> +	WMI_PEER_RESERVED8_EVENTID,
>> +	WMI_PEER_RESERVED9_EVENTID,
>> +	WMI_PEER_RESERVED10_EVENTID,
>> +	WMI_PEER_OPER_MODE_CHANGE_EVENTID,
>
> Why all these reserved ids, is it like that also in official WMI header
> definitions? Can someone from Qualcomm check this and add proper names
> for the ids?

I got confirmation privately that these are ok.

-- 
Kalle Valo

_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

  reply	other threads:[~2019-07-31 14:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-18  5:49 [PATCH 1/2] ath11k: ignore event 0x6017 John Crispin
2019-07-18  5:49 ` [PATCH 2/2] ath11k: convert message from info to dbg John Crispin
2019-07-18 11:40 ` [PATCH 1/2] ath11k: ignore event 0x6017 Kalle Valo
2019-07-31 14:55   ` Kalle Valo [this message]
2019-08-09  6:56 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878ssep81y.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    --cc=john@phrozen.org \
    --cc=slakkavalli@datto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox