From: Kalle Valo <kvalo@kernel.org>
To: Aloka Dixit <quic_alokad@quicinc.com>
Cc: <ath11k@lists.infradead.org>
Subject: Re: ath11k: QCA6390 hw2.0: firmware crashing on ath.git master branch
Date: Mon, 23 Oct 2023 19:35:05 +0300 [thread overview]
Message-ID: <87a5s9z492.fsf@kernel.org> (raw)
In-Reply-To: <7fe2972e-81fd-551e-4b61-ea804c60b0fd@quicinc.com> (Aloka Dixit's message of "Mon, 23 Oct 2023 08:18:23 -0700")
Aloka Dixit <quic_alokad@quicinc.com> writes:
> On 10/23/2023 7:34 AM, Kalle Valo wrote:
>
>> + aloka
>> Kalle Valo <kvalo@kernel.org> writes:
>> I found a reliable way to reproduce the firmware crash. I connect to
>> my
>> home network, then do 'sudo service connman stop' and boom, the firmware
>> has crashed. I suspect it has nothing to do with connman, most likely a
>> simple disconnect will suffice but I didn't bother to test that.
>> I did a git bisect and it points to Aloka's recent commit. Luckily
>> the
>> commit is only in ath-next so far and not in any release. My plan is to
>> submit a revert by tomorrow so that we get this fixed before pulling
>> ath-next into wireless-next.
>> e149353e6562f3e3246f75dfc4cca6a0cc5b4efc
>> commit e149353e6562f3e3246f75dfc4cca6a0cc5b4efc
>> Author: Aloka Dixit <quic_alokad@quicinc.com>
>> AuthorDate: Mon Oct 9 10:13:54 2023 +0300
>> Commit: Kalle Valo <quic_kvalo@quicinc.com>
>> CommitDate: Tue Oct 10 10:23:02 2023 +0300
>> wifi: ath11k: call ath11k_mac_fils_discovery() without
>> condition
>>
>
> Oh, I'm so sorry about that.
No worries, this is why we do testing :)
Once again this proves why eating your own dog food is so important[1].
> Please revert the commit, I will check what is happening and get back.
> You haven't faced this issue with the same change in ath12k right?
My ath12k testing is still quite limited. I also didn't see this on my
ath11k test box with WCN6855 but I haven't investigated this in detail.
So far I have only seen this with QCA6390.
[1] https://en.wikipedia.org/wiki/Eating_your_own_dog_food
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2023-10-23 16:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 16:26 ath11k: QCA6390 hw2.0: firmware crashing on ath.git master branch Kalle Valo
2023-10-23 14:34 ` Kalle Valo
2023-10-23 15:18 ` Aloka Dixit
2023-10-23 16:35 ` Kalle Valo [this message]
2023-10-25 22:31 ` Aloka Dixit
2023-10-26 12:08 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5s9z492.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=quic_alokad@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox