From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1ho4ih-0005qk-Rf for ath11k@lists.infradead.org; Thu, 18 Jul 2019 11:37:09 +0000 From: Kalle Valo Subject: Re: [PATCH 1/2] ath11k/hal: Fix few bugs in ath11k_hal_srng_dst_num_free() References: <1563423855-32397-1-git-send-email-vthiagar@codeaurora.org> Date: Thu, 18 Jul 2019 14:37:04 +0300 In-Reply-To: <1563423855-32397-1-git-send-email-vthiagar@codeaurora.org> (Vasanthakumar Thiagarajan's message of "Thu, 18 Jul 2019 09:54:14 +0530") Message-ID: <87blxr376n.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath11k" Errors-To: ath11k-bounces+kvalo=adurom.com@lists.infradead.org To: Vasanthakumar Thiagarajan Cc: ath11k@lists.infradead.org Vasanthakumar Thiagarajan writes: > The logic to compute the number of available buffers in destination > ring is wrong. It should be just the different between head and > tail pointers in terms of the entry size. This functions currently > unused, this is fixed to make use of this function in follow-up > patches. Also make destination ring head pointer volatile because > it is independently updated by HW. > > Signed-off-by: Vasanthakumar Thiagarajan [...] > --- a/drivers/net/wireless/ath/ath11k/hal.h > +++ b/drivers/net/wireless/ath/ath11k/hal.h > @@ -538,7 +538,7 @@ struct hal_srng { > u32 tp; > > /* Shadow head pointer location to be updated by HW */ > - u32 *hp_addr; > + volatile u32 *hp_addr; What about tp_addr, shouldn't we make that also volatile to remove the ugly cast? Can someone send another patch to fix that, please? -- Kalle Valo _______________________________________________ ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k