Re: [PATCH v4] arm64: dts: qcom: sa8775p-ride: add WiFi/BT nodes

[Kalle Valo <kvalo@kernel.org>]

Miaoqing Pan <quic_miaoqing@quicinc.com> writes:

> On 10/10/2024 10:40 PM, Dmitry Baryshkov wrote:
>> On Thu, Oct 10, 2024 at 09:59:11PM GMT, Miaoqing Pan wrote:
>>>
>>>
>>> On 10/10/2024 9:47 PM, Dmitry Baryshkov wrote:
>>>> On Thu, Oct 10, 2024 at 09:29:02PM GMT, Miaoqing Pan wrote:
>>>>> Add a node for the PMU module of the WCN6855 present on the sa8775p-ride
>>>>> board. Assign its LDO power outputs to the existing WiFi/Bluetooth module.
>>>>>
>>>>> Signed-off-by: Miaoqing Pan <quic_miaoqing@quicinc.com>
>>>>> ---
>>>>> v2:
>>>>>     - fix wcn6855-pmu compatible to "qcom,wcn6855-pmu".
>>>>>     - relocate pcieport0 node in alphabetical order.
>>>>> v3:
>>>>>     - add 'qcom,ath11k-calibration-variant = "SA8775P"'.
>>>>> v4:
>>>>>     - update 'ath11k-calibration-variant' to "Ride".
>>>>
>>>> What exactly is Ride? Is there just one Ride board? I thought it's a
>>>> board family name.
>>>
>>> I just follow the existing boards, 'Ride' is a board name. Both 'Ride' and
>>> 'Ride r3' boards are attached with WCN6855 WLAN chip.
>>>
>>> arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts:1112:
>>> qcom,ath11k-calibration-variant = "Fairphone_5";
>>> arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts:958:
>>> qcom,ath11k-calibration-variant = "SHIFTphone_8";
>>> arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts:879:	
>>> qcom,ath11k-calibration-variant = "LE_X13S";
>> There definitely are other Ride boards. I see patches related to
>> qcs8300-ride. Does that board use the same BDF file?  If not,
>> Qualcomm_SA8775P_Ride or QC_SA8775P_Ride sounds like a better approach.
>> 
>
> QCS8300 and SA8775P both use the same WiFi card, so the same BDF file
> will be used. The extra variant will increase the size of board-2.bin.

In board-2.bin one board file can have multiple names, that was designed
exactly for cases like this. So the memory inrease is just the size of
string (plus few bytes for the TLV headers).

Dmitry is correct here. It's much better to have unique names instead
trying reuse the same names for different hardware. For example, if
later we actually need different board files then that's simple to do
just in board-2.bin.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches