From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFDE1C433F5 for ; Tue, 19 Oct 2021 12:12:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 917026115A for ; Tue, 19 Oct 2021 12:12:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 917026115A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g09XHQu4+QUNUf7pplji6U8SgNsF+B1ki94ug1oRFwM=; b=Hf6bNoN4uVuy1t 2za20TYCkpEOG9edaGpDSm3XUtmgALOGSmS5gYiiuEkFna7DSUayf6C0Vc0Z5Qqq7RRmKCWn5tNyz wqZrWG0hlpIszyyKpcL3RSub2eG6rOztTxnylvkPGFjKCgF14xeAlULZur0YBsEdmGp8w6uZrWSjI I2vblFmR/zwhm0KMp7U3E58wYKSIDXW9iuuDTvyKRaGQ6MBb2gzSdBsUOGeaU7ytE1oh9XjgCS6u4 T8BrJsvFY9kjsSylFlFdw2k2zzlpTlv0MQSJNsw6CJIYTz75fKPuKnfQ6qiRd1SiVejRd8qM/XS84 T94wOyAebx0OnqHer0BA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcnz0-00150L-OT; Tue, 19 Oct 2021 12:12:42 +0000 Received: from m43-7.mailgun.net ([69.72.43.7]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcnyh-0014vt-JQ for ath11k@lists.infradead.org; Tue, 19 Oct 2021 12:12:41 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1634645558; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=oD8yCzrvHNN1ogSZeyYP+BbjUrlIhp1HkijKnjLBoV8=; b=PfE4/HAwjgqu4cOmPodalVozwsuP/BAuV3JDIqLTD37keGnvN4GL7/cbw0/ruWCLSw3+4KFN 0qGv2YuafPd9oDBGpPBjPwvLq1psQbs+IOBRSFIiGhqhcsdxTNmaAh4xtNES9966iwnj9sAV WmLS0eYAHZVtpF7sON6WG5OUIfQ= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyJmOGQ2ZiIsICJhdGgxMWtAbGlzdHMuaW5mcmFkZWFkLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 616eb61714914866fa7e2786 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 19 Oct 2021 12:12:07 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 0E299C4360C; Tue, 19 Oct 2021 12:12:07 +0000 (UTC) Received: from tykki (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id D1656C43460; Tue, 19 Oct 2021 12:12:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org D1656C43460 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org From: Kalle Valo To: Loic Poulain Cc: Manivannan Sadhasivam , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-arm-msm , regressions@lists.linux.dev, mhi Subject: Re: [regression] mhi: ath11k resume fails on some devices References: <871r5p0x2u.fsf@codeaurora.org> <877df6tlnq.fsf@codeaurora.org> <87a6jl9ndo.fsf@codeaurora.org> Date: Tue, 19 Oct 2021 15:12:01 +0300 In-Reply-To: <87a6jl9ndo.fsf@codeaurora.org> (Kalle Valo's message of "Thu, 07 Oct 2021 12:48:19 +0300") Message-ID: <87ee8hgqni.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211019_051238_335782_B6BE9570 X-CRM114-Status: GOOD ( 18.19 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org Kalle Valo writes: > (adding the new mhi list, yay) > > Hi Loic, > > Loic Poulain writes: > >>> Loic Poulain writes: >>> >>> > On Thu, 16 Sept 2021 at 10:00, Kalle Valo wrote: >>> >>> >> At the moment I'm running my tests with commit 020d3b26c07a reverted and >>> >> everything works without problems. Is there a simple way to fix this? Or >>> >> maybe we should just revert the commit? Commit log and kernel logs from >>> >> a failing case below. >>> > >>> > Do you have log of success case? >>> >>> A log from a successful case in the end of email, using v5.15-rc1 plus >>> revert of commit 020d3b26c07abe27. >>> >>> > To me, the device loses power, that is why MHI resuming is failing. >>> > Normally the device should be properly recovered/reinitialized. Before >>> > that patch the power loss was simply not detected (or handled at >>> > higher stack level). >>> >>> Currently in ath11k we always keep the firmware running when in suspend, >>> this is a workaround due to problems between mac80211 and MHI stack. >>> IIRC the problem was something related MHI creating struct device during >>> resume or something like that. >> >> Could you give a try with the attached patch? It should solve your >> issue without breaking modem support. > > Sorry for taking so long, but I now tested your patch on top of > v5.15-rc3 and, as expected, everything works as before with QCA6390 on > NUC x86 testbox. > > Tested-by: Kalle Valo I doubt we will find enough time to fully debug this mhi issue anytime soon. Can we commit Loic's patch so that this regression is resolved? At the moment I'm doing all my regression testing with commit 020d3b26c07abe27 reverted. That's a risk, I would prefer to do my testing without any hacks. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k