From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A86CBC27C53 for ; Wed, 12 Jun 2024 12:50:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GfO0bvyUfQITqg3RM0IAf12PUgDeQScKjtZWByToljI=; b=uFxrPcbBj+P4CXzC3sAVMjxvuU q9q9BORluw+t6mFZR1cr0sukuiQv+3jBPA97fOo1tY9eMXQPjM85PmuqFVioxHnSRCxFimIuYtADH Uw2N54gBa3Vl1ugJHj99/sFvdWoXN0O8m5BW/2w4BurWE3UkuMXoi5QEw1XFxOE9zn1pIOA5Wlj60 EJGgveaYcUc5YPHLpkRr4Dhb4GHizRDVablY/l0SL/RyxpGz3s6Y4sWRdplggQkH2s6aQgGxNDQjI IhIQlfwHh9CO2KDhiWK/7gwESY+Tod/VUP/nz0mHINA/Fe5TuO11OYRJLLV8X4pwiXzwbpdcOga1y 1uLrhmDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHNQR-0000000CdMX-0nC5; Wed, 12 Jun 2024 12:50:03 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHNQN-0000000CdKH-3BKp; Wed, 12 Jun 2024 12:50:01 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5738BCE1C0F; Wed, 12 Jun 2024 12:49:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94965C3277B; Wed, 12 Jun 2024 12:49:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718196596; bh=eQnr5sp7TMU5N9+uMDCu57G7uX0Piw4Oz8VKM7kfQy8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=aJ2k0Fwtt4Xb1+hzlbll1Aahwhuiw50/l5W97ntyw/wMLsB1NPLwI8RyOXHcP6scE LDeOq9eFDKNdz1Rqv+0AZh5iWyng3A3wsJw85AQP4Tgo15pNlzXsqoJNBGuC0wOBOd ePJzAeCzlYh9g1k2Ha/zf5lnnK65hoYrkznfPeoPr3YX/99a0PZkyE55ILb9Zt0QK/ 3gsNei2Yyg4Ip8d1LqdhbBnCGAd8eQhDnY8MrYVwYdkXLmzCp2M7q8kjAS659fi5oU +WZn8rsCC7RSlyfS1BDCDW79WFkX2AcfW0Xn0B3qc2Ue3XdfGm70GuI7lr4PazJTDl 8pdMRG8iYjqaw== From: Kalle Valo To: Bartosz Golaszewski Cc: Krzysztof Kozlowski , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jeff Johnson , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org, ath12k@lists.infradead.org, Bartosz Golaszewski , Krzysztof Kozlowski Subject: Re: [PATCH v9 1/2] dt-bindings: net: wireless: qcom,ath11k: describe the ath11k on QCA6390 References: <20240605122106.23818-1-brgl@bgdev.pl> <20240605122106.23818-2-brgl@bgdev.pl> <87h6e6qjuh.fsf@kernel.org> <871q5aqiei.fsf@kernel.org> <87sexqoxm9.fsf@kernel.org> <8db01c97-1cb2-4a86-abff-55176449e264@kernel.org> Date: Wed, 12 Jun 2024 15:49:51 +0300 In-Reply-To: (Bartosz Golaszewski's message of "Tue, 11 Jun 2024 22:05:57 +0200") Message-ID: <87ikyenx5c.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240612_055000_319103_7967884C X-CRM114-Status: GOOD ( 13.87 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org Bartosz Golaszewski writes: >> >> Sure, I don't need DT but that's not my point. My point is why require >> >> these supplies for _all_ devices having PCI id 17cb:1101 (ie. QCA6390) >> >> then clearly there are such devices which don't need it? To me that's >> >> bad design and, if I'm understanding correctly, prevents use of >> >> qcom,ath11k-calibration-variant property. To me having the supplies >> >> optional in DT is more approriate. >> >> >> > >> > We require them because *they are physically there*. >> >> I understand that for all known DT QCA6390 hardware, the supplies should >> be provided thus they should be required. If in the future we have >> different design or we represent some pluggable PCI card, then: >> 1. Probably that PCI card does not need power sequencing, thus no DT >> description, >> 2. If still needs power sequencing, you can always amend bindings and >> un-require the supplies. >> >> >> Best regards, >> Krzysztof >> > > Kalle, does the above answer your questions? Are these bindings good to go? To me most important is that we are on the same page that in some cases (eg. with M.2 boards) the supplies can be optional and we can update the bindings doc once such need arises (but we don't make any changes right now). Based on point 2 from Krzysztof I think we all agree, right? Just making sure: if we later change the supplies optional does that create any problems with backwards compatibility? It's important that updates go smoothly. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches