* [PATCH v2 2/4] wifi: ath11k: cleanup struct ath11k_reg_tpc_power_info
2024-11-11 7:01 [PATCH v2 1/4] wifi: ath11k: cleanup struct ath11k_vif Dmitry Antipov
@ 2024-11-11 7:01 ` Dmitry Antipov
2024-11-21 10:59 ` Kalle Valo
2024-11-11 7:01 ` [PATCH v2 3/4] wifi: ath11k: cleanup struct ath11k_mon_data Dmitry Antipov
` (4 subsequent siblings)
5 siblings, 1 reply; 10+ messages in thread
From: Dmitry Antipov @ 2024-11-11 7:01 UTC (permalink / raw)
To: Jeff Johnson; +Cc: Kalle Valo, ath11k, linux-wireless, Dmitry Antipov
Remove unused 'ap_constraint_power' field of 'struct
ath11k_reg_tpc_power_info' and adjust related comment.
Compile tested only.
Fixes: 6f4e235be655 ("wifi: ath11k: add parse of transmit power envelope element")
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
---
v2: join the series
---
drivers/net/wireless/ath/ath11k/core.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/core.h b/drivers/net/wireless/ath/ath11k/core.h
index 5ab1fdd21144..b1440a70a886 100644
--- a/drivers/net/wireless/ath/ath11k/core.h
+++ b/drivers/net/wireless/ath/ath11k/core.h
@@ -340,7 +340,6 @@ struct ath11k_chan_power_info {
* @ap_power_type: type of power (SP/LPI/VLP)
* @num_pwr_levels: number of power levels
* @reg_max: Array of maximum TX power (dBm) per PSD value
- * @ap_constraint_power: AP constraint power (dBm)
* @tpe: TPE values processed from TPE IE
* @chan_power_info: power info to send to firmware
*/
@@ -350,7 +349,6 @@ struct ath11k_reg_tpc_power_info {
enum wmi_reg_6ghz_ap_type ap_power_type;
u8 num_pwr_levels;
u8 reg_max[ATH11K_NUM_PWR_LEVELS];
- u8 ap_constraint_power;
s8 tpe[ATH11K_NUM_PWR_LEVELS];
struct ath11k_chan_power_info chan_power_info[ATH11K_NUM_PWR_LEVELS];
};
--
2.47.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v2 3/4] wifi: ath11k: cleanup struct ath11k_mon_data
2024-11-11 7:01 [PATCH v2 1/4] wifi: ath11k: cleanup struct ath11k_vif Dmitry Antipov
2024-11-11 7:01 ` [PATCH v2 2/4] wifi: ath11k: cleanup struct ath11k_reg_tpc_power_info Dmitry Antipov
@ 2024-11-11 7:01 ` Dmitry Antipov
2024-11-21 11:00 ` Kalle Valo
2024-11-11 7:01 ` [PATCH v2 4/4] wifi: ath11k: miscellaneous spelling fixes Dmitry Antipov
` (3 subsequent siblings)
5 siblings, 1 reply; 10+ messages in thread
From: Dmitry Antipov @ 2024-11-11 7:01 UTC (permalink / raw)
To: Jeff Johnson; +Cc: Kalle Valo, ath11k, linux-wireless, Dmitry Antipov
Remove initialized but otherwise unused 'rx_status_q' member of
'struct ath11k_mon_data' and adjust 'ath11k_dp_rx_pdev_mon_status_attach'
accordingly. Compile tested only.
Fixes: 67a9d399fcb0 ("ath11k: enable RX PPDU stats in monitor co-exist mode")
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
---
v2: join the series
---
drivers/net/wireless/ath/ath11k/dp.h | 1 -
drivers/net/wireless/ath/ath11k/dp_rx.c | 2 --
2 files changed, 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/dp.h b/drivers/net/wireless/ath/ath11k/dp.h
index 65d2bc0687c8..f777314db8b3 100644
--- a/drivers/net/wireless/ath/ath11k/dp.h
+++ b/drivers/net/wireless/ath/ath11k/dp.h
@@ -165,7 +165,6 @@ struct ath11k_mon_data {
struct ath11k_pdev_mon_stats rx_mon_stats;
/* lock for monitor data */
spinlock_t mon_lock;
- struct sk_buff_head rx_status_q;
};
struct ath11k_pdev_dp {
diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
index 40088e62572e..81bc93e2d05c 100644
--- a/drivers/net/wireless/ath/ath11k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
@@ -5705,8 +5705,6 @@ static int ath11k_dp_rx_pdev_mon_status_attach(struct ath11k *ar)
struct ath11k_pdev_dp *dp = &ar->dp;
struct ath11k_mon_data *pmon = (struct ath11k_mon_data *)&dp->mon_data;
- skb_queue_head_init(&pmon->rx_status_q);
-
pmon->mon_ppdu_status = DP_PPDU_STATUS_START;
memset(&pmon->rx_mon_stats, 0,
--
2.47.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v2 4/4] wifi: ath11k: miscellaneous spelling fixes
2024-11-11 7:01 [PATCH v2 1/4] wifi: ath11k: cleanup struct ath11k_vif Dmitry Antipov
2024-11-11 7:01 ` [PATCH v2 2/4] wifi: ath11k: cleanup struct ath11k_reg_tpc_power_info Dmitry Antipov
2024-11-11 7:01 ` [PATCH v2 3/4] wifi: ath11k: cleanup struct ath11k_mon_data Dmitry Antipov
@ 2024-11-11 7:01 ` Dmitry Antipov
2024-11-21 11:00 ` Kalle Valo
2024-11-11 18:08 ` [PATCH v2 1/4] wifi: ath11k: cleanup struct ath11k_vif Jeff Johnson
` (2 subsequent siblings)
5 siblings, 1 reply; 10+ messages in thread
From: Dmitry Antipov @ 2024-11-11 7:01 UTC (permalink / raw)
To: Jeff Johnson; +Cc: Kalle Valo, ath11k, linux-wireless, Dmitry Antipov
Correct spelling here and there as suggested by codespell.
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
---
v2: join the series but unchanged otherwise
---
drivers/net/wireless/ath/ath11k/hal.h | 6 +++---
drivers/net/wireless/ath/ath11k/mac.c | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/hal.h b/drivers/net/wireless/ath/ath11k/hal.h
index dc8bbe073017..601542410c75 100644
--- a/drivers/net/wireless/ath/ath11k/hal.h
+++ b/drivers/net/wireless/ath/ath11k/hal.h
@@ -700,7 +700,7 @@ enum hal_rx_buf_return_buf_manager {
#define HAL_REO_CMD_FLG_UNBLK_RESOURCE BIT(7)
#define HAL_REO_CMD_FLG_UNBLK_CACHE BIT(8)
-/* Should be matching with HAL_REO_UPD_RX_QUEUE_INFO0_UPD_* feilds */
+/* Should be matching with HAL_REO_UPD_RX_QUEUE_INFO0_UPD_* fields */
#define HAL_REO_CMD_UPD0_RX_QUEUE_NUM BIT(8)
#define HAL_REO_CMD_UPD0_VLD BIT(9)
#define HAL_REO_CMD_UPD0_ALDC BIT(10)
@@ -725,7 +725,7 @@ enum hal_rx_buf_return_buf_manager {
#define HAL_REO_CMD_UPD0_PN_VALID BIT(29)
#define HAL_REO_CMD_UPD0_PN BIT(30)
-/* Should be matching with HAL_REO_UPD_RX_QUEUE_INFO1_* feilds */
+/* Should be matching with HAL_REO_UPD_RX_QUEUE_INFO1_* fields */
#define HAL_REO_CMD_UPD1_VLD BIT(16)
#define HAL_REO_CMD_UPD1_ALDC GENMASK(18, 17)
#define HAL_REO_CMD_UPD1_DIS_DUP_DETECTION BIT(19)
@@ -741,7 +741,7 @@ enum hal_rx_buf_return_buf_manager {
#define HAL_REO_CMD_UPD1_PN_HANDLE_ENABLE BIT(30)
#define HAL_REO_CMD_UPD1_IGNORE_AMPDU_FLG BIT(31)
-/* Should be matching with HAL_REO_UPD_RX_QUEUE_INFO2_* feilds */
+/* Should be matching with HAL_REO_UPD_RX_QUEUE_INFO2_* fields */
#define HAL_REO_CMD_UPD2_SVLD BIT(10)
#define HAL_REO_CMD_UPD2_SSN GENMASK(22, 11)
#define HAL_REO_CMD_UPD2_SEQ_2K_ERR BIT(23)
diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index 9757ac4aae50..31ae9b384a29 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -2228,7 +2228,7 @@ static void ath11k_peer_assoc_h_vht(struct ath11k *ar,
__le16_to_cpu(vht_cap->vht_mcs.tx_mcs_map), vht_mcs_mask);
/* In IPQ8074 platform, VHT mcs rate 10 and 11 is enabled by default.
- * VHT mcs rate 10 and 11 is not suppoerted in 11ac standard.
+ * VHT mcs rate 10 and 11 is not supported in 11ac standard.
* so explicitly disable the VHT MCS rate 10 and 11 in 11ac mode.
*/
arg->tx_mcs_set &= ~IEEE80211_VHT_MCS_SUPPORT_0_11_MASK;
@@ -6950,7 +6950,7 @@ static void ath11k_mac_op_remove_interface(struct ieee80211_hw *hw,
/* Recalc txpower for remaining vdev */
ath11k_mac_txpower_recalc(ar);
- /* TODO: recal traffic pause state based on the available vdevs */
+ /* TODO: recalc traffic pause state based on the available vdevs */
mutex_unlock(&ar->conf_mutex);
}
--
2.47.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v2 1/4] wifi: ath11k: cleanup struct ath11k_vif
2024-11-11 7:01 [PATCH v2 1/4] wifi: ath11k: cleanup struct ath11k_vif Dmitry Antipov
` (2 preceding siblings ...)
2024-11-11 7:01 ` [PATCH v2 4/4] wifi: ath11k: miscellaneous spelling fixes Dmitry Antipov
@ 2024-11-11 18:08 ` Jeff Johnson
2024-11-21 10:59 ` Kalle Valo
2024-11-21 16:12 ` Jeff Johnson
5 siblings, 0 replies; 10+ messages in thread
From: Jeff Johnson @ 2024-11-11 18:08 UTC (permalink / raw)
To: Dmitry Antipov, Jeff Johnson; +Cc: Kalle Valo, ath11k, linux-wireless
For future reference a multi-patch patchset is much easier to track if it has
a cover letter with a subject that describes the entire patchset.
/jeff
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v2 1/4] wifi: ath11k: cleanup struct ath11k_vif
2024-11-11 7:01 [PATCH v2 1/4] wifi: ath11k: cleanup struct ath11k_vif Dmitry Antipov
` (3 preceding siblings ...)
2024-11-11 18:08 ` [PATCH v2 1/4] wifi: ath11k: cleanup struct ath11k_vif Jeff Johnson
@ 2024-11-21 10:59 ` Kalle Valo
2024-11-21 16:12 ` Jeff Johnson
5 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2024-11-21 10:59 UTC (permalink / raw)
To: Dmitry Antipov; +Cc: Jeff Johnson, ath11k, linux-wireless
Dmitry Antipov <dmantipov@yandex.ru> writes:
> Remove set but otherwise unused 'tx_seq_no' member of 'struct ath11k_vif',
> adjust 'ath11k_control_beaconing()' accordingly. This field was actually
> unused since an initial commit of the driver. Compile tested only.
>
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Acked-by: Kalle Valo <kvalo@kernel.org>
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v2 1/4] wifi: ath11k: cleanup struct ath11k_vif
2024-11-11 7:01 [PATCH v2 1/4] wifi: ath11k: cleanup struct ath11k_vif Dmitry Antipov
` (4 preceding siblings ...)
2024-11-21 10:59 ` Kalle Valo
@ 2024-11-21 16:12 ` Jeff Johnson
5 siblings, 0 replies; 10+ messages in thread
From: Jeff Johnson @ 2024-11-21 16:12 UTC (permalink / raw)
To: Jeff Johnson, Dmitry Antipov; +Cc: Kalle Valo, ath11k, linux-wireless
On Mon, 11 Nov 2024 10:01:49 +0300, Dmitry Antipov wrote:
> Remove set but otherwise unused 'tx_seq_no' member of 'struct ath11k_vif',
> adjust 'ath11k_control_beaconing()' accordingly. This field was actually
> unused since an initial commit of the driver. Compile tested only.
>
>
Applied, thanks!
[1/4] wifi: ath11k: cleanup struct ath11k_vif
commit: 733a8c69ded704616b864d30d2531d090ee7a57e
[2/4] wifi: ath11k: cleanup struct ath11k_reg_tpc_power_info
commit: 95e5de4aae8ca1af851fc922a854bbe822bf2dd4
[3/4] wifi: ath11k: cleanup struct ath11k_mon_data
commit: 93962446ef907cb169b089d0ff3f356e7ce004ab
[4/4] wifi: ath11k: miscellaneous spelling fixes
commit: 8f5e8e7efb135fc648abbb572bd86d0c96819eaf
Best regards,
--
Jeff Johnson <quic_jjohnson@quicinc.com>
^ permalink raw reply [flat|nested] 10+ messages in thread