From: Kalle Valo <kvalo@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: <ath11k@lists.infradead.org>
Subject: Re: [PATCH 2/2] ath11k: mhi: use mhi_sync_power_up()
Date: Fri, 28 Jan 2022 11:06:20 +0200 [thread overview]
Message-ID: <87k0eki60j.fsf@kernel.org> (raw)
In-Reply-To: <a0f8c8fa-2f26-e522-a3b9-e530aba9994b@quicinc.com> (Jeff Johnson's message of "Thu, 27 Jan 2022 15:36:54 -0800")
Jeff Johnson <quic_jjohnson@quicinc.com> writes:
> On 1/27/2022 1:01 AM, Kalle Valo wrote:
>> From: Kalle Valo <quic_kvalo@quicinc.com>
>>
>> If amss.bin was missing ath11k would crash during 'rmmod ath11k_pci'. The
>> reason for that was that we were using mhi_async_power_up() which does not
>> check any errors. But mhi_sync_power_up() on the other hand does check for
>> errors so let's use that to fix the crash.
>>
>> I was not able to find a reason why an async version was used. This call ends
>> is called from ath11k_hif_power_up() which can sleep, so sync version should be
>> safe to use.
>
> I could not parse the 2nd sentence: This call ends is called
Heh, that is a pretty horrible sentence. How about this:
"ath11k_mhi_start() (which enables state ATH11K_MHI_POWER_ON) is called
from ath11k_hif_power_up(), which can sleep. So sync version should be
safe to use here."
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2022-01-28 9:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 9:01 [PATCH 1/2] ath11k: pci: fix crash on suspend if board file is not found Kalle Valo
2022-01-27 9:01 ` [PATCH 2/2] ath11k: mhi: use mhi_sync_power_up() Kalle Valo
2022-01-27 23:36 ` Jeff Johnson
2022-01-28 9:06 ` Kalle Valo [this message]
2022-01-31 14:11 ` [PATCH 1/2] ath11k: pci: fix crash on suspend if board file is not found Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0eki60j.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox