From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08BF2C07545 for ; Tue, 24 Oct 2023 14:07:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L6iGwJo+l5bYtBLgR9+tR3RzxMQ0OW25kSP32VsjRD8=; b=tUnQiRsq4wgM5e 7/nKoAPEny3cadEwRsTcr5jgzRF4//jR9DpUqrEMZbK588YsqE8gW+Shmac73BMxe+8HBuJ1Dsc5Z K92onoBXN5F03g6dXW/DPmIouez5pUeMV5eKB96rf9HQp/tYr+CmW5UeTI1dfCXppXMTByymc1jzO mkOnBZ9Ymhd2+yW7mmLDY45m5byPEjwgXG+6KSsjGMe3b6P1w1PZUME+UkcFgfiSr49MIiCtxtBZm 796COflkuN38jpbiBEnMTHORK9XnIfaQA1WohEKptwKclOG8kiAdBeHqC0NwymF3Xw3s/r+ESkwoP fAMl13PeYR04h7AX45mQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qvI4P-00A5Un-18; Tue, 24 Oct 2023 14:07:45 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qvI4N-00A5UN-05 for ath11k@lists.infradead.org; Tue, 24 Oct 2023 14:07:44 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8E1AC61265; Tue, 24 Oct 2023 14:07:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10A78C433C8; Tue, 24 Oct 2023 14:07:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698156462; bh=9jC8oNZgHX1Zi6aWIvKR5WIBscBYWtT/XNF7Ji+UiB8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=gXC+envN88pZ16F8KzAjczjiWBqEKfHwpJD0p7P+wmzdB+o7NwKEiLXAFTNwGw/1g dieOYHrquj917Fj/nh2ar4Oc8Wj2kFU+RX8UHAM2mzCoTWHtvOteXl2tsuuLYEvOpV vhzNHq5eF96otmpUqWODLhOHYs0IfVbpKVmsjrwylxLKKgTAk8QVJUarSBxggH+LZv 9i00MapnXdOhEsMDCibsxQUOp13U/KyXxxJWIPHsUoJ3lwq3tzXcjuLzexDz/vbXRK Si+n9xhtkO/wslDcK+pBQlm2SmySgNzvQuF0myT1gavca1fWMSqLJOW2UX0A4RLgpj fctl56uXy/gww== From: Kalle Valo To: Johan Hovold Cc: Jeff Johnson , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] wifi: ath11k: fix event locking References: <20231019153115.26401-1-johan+linaro@kernel.org> Date: Tue, 24 Oct 2023 17:07:38 +0300 In-Reply-To: <20231019153115.26401-1-johan+linaro@kernel.org> (Johan Hovold's message of "Thu, 19 Oct 2023 17:31:13 +0200") Message-ID: <87o7goxget.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231024_070743_127721_98B70896 X-CRM114-Status: GOOD ( 10.30 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org Johan Hovold writes: > RCU lockdep reported suspicious RCU usage when accessing the temperature > sensor. Inspection revealed that the DFS radar event code was also > missing the required RCU read-side critical section marking. > > Johan > > > Changes in v2 > - add the missing rcu_read_unlock() to an > ath11k_wmi_pdev_temperature_event() error path as noticed by Jeff > > > Johan Hovold (2): > wifi: ath11k: fix temperature event locking > wifi: ath11k: fix dfs radar event locking Thanks for the fixes. I really like using lockdep_assert_held() to document if a function requires some lock held, is there anything similar for RCU? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k