ATH11K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: John Crispin <john@phrozen.org>
Cc: ath11k@lists.infradead.org,
	Shashidhar Lakkavalli <slakkavalli@datto.com>
Subject: Re: [PATCH V6 03/11] ath11k: move phymode selection from function to array lookup
Date: Wed, 29 May 2019 18:47:56 +0300	[thread overview]
Message-ID: <87pno11cur.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20190528064803.24419-4-john@phrozen.org> (John Crispin's message of "Tue, 28 May 2019 08:47:55 +0200")

John Crispin <john@phrozen.org> writes:

> With HE support getting added, the approach of using functions will quickly
> get convoluted. Change the code to use an array lookup function instead.
>
> Signed-off-by: Shashidhar Lakkavalli <slakkavalli@datto.com>
> Signed-off-by: John Crispin <john@phrozen.org>
> ---
>  drivers/net/wireless/ath/ath11k/mac.c | 117 ++++++++++++--------------
>  include/uapi/linux/nl80211.h          |   4 +
>  2 files changed, 57 insertions(+), 64 deletions(-)
>

[...]

> diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h
> index dd4f86ee286e..b6e29161ec8b 100644
> --- a/include/uapi/linux/nl80211.h
> +++ b/include/uapi/linux/nl80211.h
> @@ -4162,6 +4162,10 @@ enum nl80211_chan_width {
>  	NL80211_CHAN_WIDTH_160,
>  	NL80211_CHAN_WIDTH_5,
>  	NL80211_CHAN_WIDTH_10,
> +
> +	/* keep last */
> +	__NL80211_CHAN_WIDTH_NUM,
> +	NL80211_CHAN_WIDTH_MAX = __NL80211_CHAN_WIDTH_NUM - 1,

I was wondering why this patchset was giving warnings on ath10k and then
I found this. In an ath11k patch you can't change anything outside of
ath11k. So you have to send this to upstream as a separate patch. Or
maybe modify the ath11k part so that no changes in nl80211.h is needed.

And then you change nl80211 do make sure that you compile testing all
drivers.

-- 
Kalle Valo

_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

  reply	other threads:[~2019-05-29 15:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-28  6:47 [PATCH V6 00/11] ath11k: add HE support John Crispin
2019-05-28  6:47 ` [PATCH V6 01/11] mac80211: propagate HE operation info into bss_conf John Crispin
2019-05-28  6:47 ` [PATCH V6 02/11] ath11k: fix some whitespace errors John Crispin
2019-05-28  6:47 ` [PATCH V6 03/11] ath11k: move phymode selection from function to array lookup John Crispin
2019-05-29 15:47   ` Kalle Valo [this message]
2019-05-28  6:47 ` [PATCH V6 04/11] ath11k: add HE handling to the debug code John Crispin
2019-05-28  6:47 ` [PATCH V6 05/11] ath11k: extend reading of FW capabilities John Crispin
2019-05-28  6:47 ` [PATCH V6 06/11] ath11k: add defines for max MCS rates per phymode John Crispin
2019-05-28  6:47 ` [PATCH V6 07/11] ath11k: handle rx status for HE frames John Crispin
2019-05-28  6:48 ` [PATCH V6 08/11] ath11k: add HE support John Crispin
2019-05-28  6:48 ` [PATCH V6 09/11] ath11k: add sta_statistics callback John Crispin
2019-05-29 15:30   ` Kalle Valo
2019-05-28  6:48 ` [PATCH V6 10/11] ath11k: properly convert bw John Crispin
2019-05-29 15:31   ` Kalle Valo
2019-05-28  6:48 ` [PATCH V6 11/11] ath11k: add HE rate reporting John Crispin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pno11cur.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    --cc=john@phrozen.org \
    --cc=slakkavalli@datto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox