From: Kalle Valo <kvalo@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: <ath11k@lists.infradead.org>
Subject: Re: [PATCH v2] ath11k: add signal report to mac80211 for QCA6390 and WCN6855
Date: Mon, 20 Dec 2021 20:27:51 +0200 [thread overview]
Message-ID: <87r1a79lnc.fsf@codeaurora.org> (raw)
In-Reply-To: <34610fb9-d9ec-0cb8-f58f-fe82fe96002c@quicinc.com> (Jeff Johnson's message of "Thu, 16 Dec 2021 15:32:31 -0800")
Jeff Johnson <quic_jjohnson@quicinc.com> writes:
> On 12/15/2021 11:05 PM, Wen Gong wrote:
>> IEEE80211_HW_USES_RSS is set in ath11k, then the device uses RSS and
>> thus requires parallel RX which implies using per-CPU station statistics
>> in sta_get_last_rx_stats() of mac80211. Currently signal is only set in
>> ath11k_mgmt_rx_event(), and not set for RX data packet, then it show
>> signal as 0 for iw command easily.
>>
>> Change to get signal from firmware and report to mac80211.
>>
>> For QCA6390 and WCN6855, the rssi value is already in dbm unit, so
>> don't need to convert it again.
>>
>> Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1
>> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1
>>
>> Signed-off-by: Wen Gong <quic_wgong@quicinc.com>
[...]
>> @@ -7843,9 +7846,22 @@ static void ath11k_mac_op_sta_statistics(struct ieee80211_hw *hw,
>> ath11k_mac_put_chain_rssi(sinfo, arsta, "fw stats", true);
>> }
>> - /* TODO: Use real NF instead of default one. */
>> - sinfo->signal = arsta->rssi_comb + ATH11K_DEFAULT_NOISE_FLOOR;
>> - sinfo->filled |= BIT_ULL(NL80211_STA_INFO_SIGNAL);
>> + signal = arsta->rssi_comb;
>> + if (!signal &&
>> + arsta->arvif->vdev_type == WMI_VDEV_TYPE_STA &&
>> + ar->ab->hw_params.supports_rssi_stats &&
>> + !(ath11k_debugfs_get_fw_stats(ar, ar->pdev->pdev_id, 0,
>> + WMI_REQUEST_VDEV_STAT)))
>
> what happens when CONFIG_ATH11K_DEBUGFS is not enabled?
I suspect it won't work.
> should the logic to get the stats be decoupled from DebugFS support?
Yes, I think it should be. But better to do it in a separate patch.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2021-12-20 18:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 7:05 [PATCH v2] ath11k: add signal report to mac80211 for QCA6390 and WCN6855 Wen Gong
2021-12-16 23:32 ` Jeff Johnson
2021-12-20 18:27 ` Kalle Valo [this message]
2021-12-20 16:07 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1a79lnc.fsf@codeaurora.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox