From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF38DC433EF for ; Thu, 16 Sep 2021 15:16:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FBCC61216 for ; Thu, 16 Sep 2021 15:16:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6FBCC61216 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qqvu1LRBjJZhACzf9/E9AFCp0OnqZfIuAl/PS8Kha1k=; b=EtP+Vk1nxCtQkT JaJbq1aiNnQ93gZJL6xE0uJW6JJXE/WBqyekx2EmQWKxbfMRqPNDxsyLGfJT4maEGTAS6Ky3kesex ADf3XeA41NYGVxWBybf5O69ucepxa0mxvAQl+Ee19zZXjpO0HdLxGn/kjDWzEsux+jnOjY7B2Omz8 sP4zP+pMxwndFuirXCwKMTt9T+G5Y8vqUcIiGN2j0D+gJkzalLpZTPC1mqPgDXK6V/rItFWApjhdm KiH/xawFuhcHnN7iC2RsuyF/8FcLNU+cIl7CqQKKJ7+wqRvmlfMazeb+oj76s3apUzM9aqjWRS1bu ElZDIrzjYCvlpN4MZsMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQt7L-00BQQW-C5; Thu, 16 Sep 2021 15:16:03 +0000 Received: from m43-7.mailgun.net ([69.72.43.7]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQt7G-00BQPh-G3 for ath11k@lists.infradead.org; Thu, 16 Sep 2021 15:16:02 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1631805360; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=DJLzVfi8VhO4JuesZSVhb2rfe1QgDSqTxydNPHq/dXk=; b=vTTzpYf0xrGsLp/tGNjcna2m87C3H99gjqM/Kqj/mj28ILEIrVJpO/6Xcoy0y1cT3mL+RTVO ksCsgrV1nBVAUBm6S2URJGdBFzlws0uUnJAXnzpH4ZmGuN9x8f2Vbv3mMki6f/fy4NbT23ll qU78nv4YdaEaI2yeN0CS5h+MfrM= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyJmOGQ2ZiIsICJhdGgxMWtAbGlzdHMuaW5mcmFkZWFkLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-east-1.postgun.com with SMTP id 61435fa8c1b30e2f0238a87d (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 16 Sep 2021 15:15:52 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id DE22BC43618; Thu, 16 Sep 2021 15:15:51 +0000 (UTC) Received: from tykki (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id D209FC4338F; Thu, 16 Sep 2021 15:15:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org D209FC4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org From: Kalle Valo To: Wen Gong Cc: Jouni Malinen , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH 3/3] ath11k: set correct NL80211_FEATURE_DYNAMIC_SMPS for WCN6855 References: <20210914163726.38604-1-jouni@codeaurora.org> <20210914163726.38604-3-jouni@codeaurora.org> <875yv0zvcn.fsf@codeaurora.org> <6ec81d2b9ec3a2665570baf90e624bf5@codeaurora.org> Date: Thu, 16 Sep 2021 18:15:46 +0300 In-Reply-To: <6ec81d2b9ec3a2665570baf90e624bf5@codeaurora.org> (Wen Gong's message of "Thu, 16 Sep 2021 22:09:00 +0800") Message-ID: <87sfy4y2jh.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210916_081600_839477_EBC54CB4 X-CRM114-Status: GOOD ( 14.71 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org Wen Gong writes: > On 2021-09-16 18:08, Kalle Valo wrote: >> Jouni Malinen writes: >> >>> From: Wen Gong >>> >>> Commit "ath11k: support SMPS configuration for 6 GHz" changed "if >>> (ht_cap & WMI_HT_CAP_DYNAMIC_SMPS)" to "if (ht_cap & >>> WMI_HT_CAP_DYNAMIC_SMPS || ar->supports_6ghz)" which means >>> NL80211_FEATURE_DYNAMIC_SMPS is enabled for all chips which support 6 >>> GHz. However, WCN6855 supports 6 GHz but it does not support feature >>> NL80211_FEATURE_DYNAMIC_SMPS, and this can lead to MU-MIMO test >>> failures >>> for WCN6855. >>> >>> Disable NL80211_FEATURE_DYNAMIC_SMPS for WCN6855 since its ht_cap does >>> not support WMI_HT_CAP_DYNAMIC_SMPS. >>> >>> Tested-on: WCN6855 hw2.0 PCI >>> WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1 >>> >>> Signed-off-by: Wen Gong >>> Signed-off-by: Jouni Malinen >> >> [...] >> >>> --- a/drivers/net/wireless/ath/ath11k/mac.c >>> +++ b/drivers/net/wireless/ath/ath11k/mac.c >>> @@ -7570,7 +7570,8 @@ static int __ath11k_mac_register(struct >>> ath11k *ar) >>> * for each band for a dual band capable radio. It will be tricky to >>> * handle it when the ht capability different for each band. >>> */ >>> - if (ht_cap & WMI_HT_CAP_DYNAMIC_SMPS || ar->supports_6ghz) >>> + if (ht_cap & WMI_HT_CAP_DYNAMIC_SMPS || >>> + (ar->supports_6ghz && !ab->hw_params.check_dynamic_smps)) >>> ar->hw->wiphy->features |= NL80211_FEATURE_DYNAMIC_SMPS; >>> >>> ar->hw->wiphy->max_scan_ssids = WLAN_SCAN_PARAMS_MAX_SSID; >> >> This hunk failed, in the pending branch as I don't have that >> ar->supports_6ghz check. I'll drop this patch 3 for now, let's revisit >> after my queue of ath11k patches is smaller. > > ar->supports_6ghz is introduced by this patch: > https://patchwork.kernel.org/project/linux-wireless/patch/20210913175510.193005-3-jouni@codeaurora.org/ Ah, and that was in Awaiting Upstream state and not yet in my pending branch. I'll take that patchset first to pending branch and then apply this patch 3, so no need to resend anything (at least for the moment). -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k