From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7428C433F5 for ; Thu, 16 Sep 2021 09:35:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD3D1610E9 for ; Thu, 16 Sep 2021 09:35:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AD3D1610E9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HY1BkbzWkSPff7yPFTBl+bXmfeWG8FJFqI+OEuzZNUQ=; b=U3d+NEAIekDM/i BkcTGKMMynR7yX8fLkLccIicd70BbO95DM3S9+7IU5C6rl9pcueesZm34eegSxaHu0ck6lz9ivZO9 qVBIEgPkAGgdtekrwoO7LJCQw2jKBgfYnZqISQDK6DHch6+7gFD5m5pedM3SnvV+X5+SuGahgeN3i pONujcdaeYLOiJgkz5QpbsYGPuJBqwthzoLkye1NPw++cO93ALBBaXmsKCCycbCrtPHGk5p3U+wbT c3lb1A0peMoRiGLeX511rxy8+mrsODiy3ONry7vxDqiCGBxc/HWun6vpke3fce7mFmZyMO6mGkD4u ogbiHxOskmlf8Omtg5jQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQnoA-00AirM-JA; Thu, 16 Sep 2021 09:35:54 +0000 Received: from so254-9.mailgun.net ([198.61.254.9]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQno7-00AipY-Jo for ath11k@lists.infradead.org; Thu, 16 Sep 2021 09:35:53 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1631784951; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=Dlno9iZgVTyWpqnJjOxv4E/8xZlHwmErWjAI6J5ici4=; b=HqpcdTfl+LWIq4wvEpFhQ5DieVSdg7WhTZSOvyXtq/0Jsumk1atV03hS75wbHoWELn2LMQ2k rXxxW50wJfhenrJrg2jAPZlezbJJm6H46Al8+vsfvO/gpiMdeX1MZdfY2lsuW3CSDzeAA05M gyGd0NJ3gfD6uJAE0RVPd3ci0fg= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyJmOGQ2ZiIsICJhdGgxMWtAbGlzdHMuaW5mcmFkZWFkLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-west-2.postgun.com with SMTP id 61430ff6648642cc1c536ec6 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 16 Sep 2021 09:35:50 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 314F4C43460; Thu, 16 Sep 2021 09:35:50 +0000 (UTC) Received: from tykki (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 4C5CFC4338F; Thu, 16 Sep 2021 09:35:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 4C5CFC4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org From: Kalle Valo To: Jouni Malinen Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, Seevalamuthu Mariappan , Miles Hu , Vasanthakumar Thiagarajan Subject: Re: [PATCH 3/3] ath11k: monitor mode clean up to use separate APIs References: <20210721162053.46290-1-jouni@codeaurora.org> <20210721162053.46290-4-jouni@codeaurora.org> Date: Thu, 16 Sep 2021 12:35:45 +0300 In-Reply-To: <20210721162053.46290-4-jouni@codeaurora.org> (Jouni Malinen's message of "Wed, 21 Jul 2021 19:20:53 +0300") Message-ID: <87sfy4zwum.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210916_023551_762096_CF35E016 X-CRM114-Status: GOOD ( 10.96 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org Jouni Malinen writes: > From: Seevalamuthu Mariappan > > If monitor interface is enabled in co-exist mode, only local traffic are > captured. It's caused by missing monitor vdev in co-exist mode. So, > monitor mode clean up is done with separate Monitor APIs. For this, > introduce monitor_started and monitor_vdev_created boolean flags. > > Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-01725-QCAHKSWPL_SILICONZ-1 Seevalamuthu, in upstream IPQ8074 doesn't even support monitor mode: static const struct ath11k_hw_params ath11k_hw_params[] = { { .hw_rev = ATH11K_HW_IPQ8074, .name = "ipq8074 hw2.0", ... .interface_modes = BIT(NL80211_IFTYPE_STATION) | BIT(NL80211_IFTYPE_AP) | BIT(NL80211_IFTYPE_MESH_POINT), So I wonder how did you test this? Is this something which is only tested on ancient QSDK kernels and not with upstream kernels? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k