From: Kalle Valo <kvalo@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Christian 'Ansuel' Marangi <ansuelsmth@gmail.com>,
<ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/2] ath11k: fix missing skb drop on htc_tx_completion error
Date: Wed, 01 Jun 2022 09:18:57 +0300 [thread overview]
Message-ID: <87v8tkoqi6.fsf@kernel.org> (raw)
In-Reply-To: <cfb03aa3-1a98-8131-0090-93c8ae918e7f@quicinc.com> (Jeff Johnson's message of "Tue, 31 May 2022 13:32:18 -0700")
Jeff Johnson <quic_jjohnson@quicinc.com> writes:
> On 5/28/2022 7:25 AM, Christian 'Ansuel' Marangi wrote:
>> On htc_tx_completion error the skb is not dropped. This is wrong since
>> the completion_handler logic expect the skb to be consumed anyway even
>> when an error is triggerer. Not freeing the skb on error is a memory
>
> nit: s/triggerer/triggered/
>
> Kalle can fix this when he merges so no need to post a correction
Yup, fixed now in the pending branch.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2022-06-01 6:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-28 14:25 [PATCH 1/2] ath11k: fix missing srng_access_end in CE Christian 'Ansuel' Marangi
2022-05-28 14:25 ` [PATCH 2/2] ath11k: fix missing skb drop on htc_tx_completion error Christian 'Ansuel' Marangi
2022-05-31 20:32 ` Jeff Johnson
2022-06-01 6:18 ` Kalle Valo [this message]
2022-06-06 14:07 ` Kalle Valo
2022-06-01 19:09 ` [PATCH 1/2] ath11k: fix missing srng_access_end in CE Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8tkoqi6.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox