From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWib2-0006tN-R8 for ath11k@lists.infradead.org; Fri, 31 May 2019 14:33:30 +0000 From: Kalle Valo Subject: Re: Remaining sparse warnings References: <874l5dqkl2.fsf@codeaurora.org> <97b7a885-d357-c1e0-330e-44d00566f1e5@qti.qualcomm.com> Date: Fri, 31 May 2019 17:33:19 +0300 In-Reply-To: <97b7a885-d357-c1e0-330e-44d00566f1e5@qti.qualcomm.com> (Vasanthakumar Thiagarajan's message of "Fri, 31 May 2019 03:51:43 +0000") Message-ID: <87v9xqzob4.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath11k" Errors-To: ath11k-bounces+kvalo=adurom.com@lists.infradead.org To: Vasanthakumar Thiagarajan Cc: "ath11k@lists.infradead.org" Vasanthakumar Thiagarajan writes: > On Wednesday 29 May 2019 10:11 PM, Kalle Valo wrote: >> >> there are still few sparse warnings, anyone willing to fix the last >> ones? Though I'm not sure how to fix "dubious: x & !y" warnings, any >> ideas? >> >> drivers/net/wireless/ath/ath11k/hal_rx.c:118:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:120:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:122:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:124:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:126:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:128:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:130:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:132:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:134:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:136:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:138:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:140:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:142:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:144:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:146:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:148:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:150:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:152:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:154:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:156:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:158:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:160:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:166:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:170:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:172:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:176:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:178:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:180:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:182:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:184:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:186:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:188:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:190:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:192:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:212:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:216:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/hal_rx.c:218:17: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/dp_tx.c:665:23: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/dp_tx.c:667:23: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/dp_tx.c:670:23: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/dp_tx.c:830:23: warning: dubious: x & !y >> drivers/net/wireless/ath/ath11k/dp_tx.c:832:23: warning: dubious: x & !y > > To me, this seems like a false warning, I do not see any issue with > the way values are passed > to FIELD_PREP() macro. Me neither. I think I'll filter out all "dubious:" warnings in my ath11k-check script for now. Let's just hope we don't miss any real warnings because of this. >> drivers/net/wireless/ath/ath11k/dp_tx.c:837:33: warning: incorrect >> type in assignment (different base types) >> drivers/net/wireless/ath/ath11k/dp_tx.c:837:33: expected unsigned >> int [usertype] pkt_type_en_flags0 >> drivers/net/wireless/ath/ath11k/dp_tx.c:837:33: got restricted __le32 [usertype] >> drivers/net/wireless/ath/ath11k/dp_tx.c:838:33: warning: incorrect >> type in assignment (different base types) >> drivers/net/wireless/ath/ath11k/dp_tx.c:838:33: expected unsigned >> int [usertype] pkt_type_en_flags1 >> drivers/net/wireless/ath/ath11k/dp_tx.c:838:33: got restricted __le32 [usertype] >> drivers/net/wireless/ath/ath11k/dp_tx.c:839:33: warning: incorrect >> type in assignment (different base types) >> drivers/net/wireless/ath/ath11k/dp_tx.c:839:33: expected unsigned >> int [usertype] pkt_type_en_flags2 >> drivers/net/wireless/ath/ath11k/dp_tx.c:839:33: got restricted __le32 [usertype] >> drivers/net/wireless/ath/ath11k/dp_tx.c:840:33: warning: incorrect >> type in assignment (different base types) >> drivers/net/wireless/ath/ath11k/dp_tx.c:840:33: expected unsigned >> int [usertype] pkt_type_en_flags3 >> drivers/net/wireless/ath/ath11k/dp_tx.c:840:33: got restricted __le32 [usertype] >> drivers/net/wireless/ath/ath11k/dp_tx.c:841:28: warning: incorrect >> type in assignment (different base types) >> drivers/net/wireless/ath/ath11k/dp_tx.c:841:28: expected unsigned >> int [usertype] rx_filter_tlv >> drivers/net/wireless/ath/ath11k/dp_tx.c:841:28: got restricted __le32 [usertype] >> > > Ill take a loot at these warnings. Thanks! -- Kalle Valo _______________________________________________ ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k