ATH11K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCH 2/2] ath11k: add thermal sensor device support
Date: Tue, 11 Feb 2020 15:49:19 +0200	[thread overview]
Message-ID: <87zhdpw7xc.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1580860830-12696-2-git-send-email-pradeepc@codeaurora.org> (Pradeep Kumar Chitrapu's message of "Wed, 5 Feb 2020 05:30:30 +0530")

Pradeep Kumar Chitrapu <pradeepc@codeaurora.org> writes:

> Temperature sensor generates electrical analog voltage from temperature
> of each chain. The analog voltage is converted to digital value through
> ADC. For reading temperature values fom user space, hw monitoring device
> is used.
>
> Whenever the user requests for current temperature, the driver sends WMI
> command and wait for response. For reading temperature,
>
> cat /sys/class/ieee80211/phy*/device/hwmon/hwmon2/temp1_input
>
> Signed-off-by: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>

Multiple warnings, please fix those and resend the whole series.

drivers/net/wireless/ath/ath11k/wmi.c: In function 'ath11k_wmi_tlv_op_rx':
drivers/net/wireless/ath/ath11k/wmi.c:5651:7: warning: 'pdev_id' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/net/wireless/ath/ath11k/wmi.c:5641:6: note: 'pdev_id' was declared here
drivers/net/wireless/ath/ath11k/wmi.c:5657:2: warning: 'temp' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/net/wireless/ath/ath11k/wmi.c:5640:6: note: 'temp' was declared here
drivers/net/wireless/ath/ath11k/wmi.c: In function 'ath11k_wmi_tlv_op_rx':
drivers/net/wireless/ath/ath11k/wmi.c:5651:7: warning: 'pdev_id' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/net/wireless/ath/ath11k/wmi.c:5641:6: note: 'pdev_id' was declared here
drivers/net/wireless/ath/ath11k/wmi.c:5657:2: warning: 'temp' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/net/wireless/ath/ath11k/wmi.c:5640:6: note: 'temp' was declared here

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

  reply	other threads:[~2020-02-11 13:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-05  0:00 [PATCH 1/2] ath11k: add thermal cooling device support Pradeep Kumar Chitrapu
2020-02-05  0:00 ` [PATCH 2/2] ath11k: add thermal sensor " Pradeep Kumar Chitrapu
2020-02-11 13:49   ` Kalle Valo [this message]
2020-02-05 18:14 ` [PATCH 1/2] ath11k: add thermal cooling " John Crispin
2020-02-11 13:34 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhdpw7xc.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pradeepc@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox