From: Johannes Berg <johannes@sipsolutions.net>
To: Sven Eckelmann <sven@narfation.org>, linux-wireless@vger.kernel.org
Cc: ath11k@lists.infradead.org, Sven Eckelmann <seckelmann@datto.com>
Subject: Re: [PATCH v3 2/3] mac80211: implement HE support for mesh
Date: Fri, 14 Jun 2019 16:11:15 +0200 [thread overview]
Message-ID: <8d0d11ca39b6216b24cf4e9e3a1522072db5c0d2.camel@sipsolutions.net> (raw)
In-Reply-To: <20190612193510.29489-3-sven@narfation.org> (sfid-20190612_213644_171180_98373DED)
On Wed, 2019-06-12 at 21:35 +0200, Sven Eckelmann wrote:
>
> +u8 ieee80211_ie_len_he_cap(struct ieee80211_sub_if_data *sdata)
> +{
> + const struct ieee80211_sta_he_cap *he_cap;
> + struct ieee80211_supported_band *sband;
> + u8 ie_len;
> + u8 n;
> +
> + sband = ieee80211_get_sband(sdata);
> + if (!sband)
> + return 0;
> +
> + he_cap = ieee80211_get_he_mesh_cap(sband);
> + if (!he_cap)
> + return 0;
> +
> + n = ieee80211_he_mcs_nss_size(&he_cap->he_cap_elem);
> + ie_len = 2 + 1 +
> + sizeof(he_cap->he_cap_elem) + n +
> + ieee80211_he_ppe_size(he_cap->ppe_thres[0],
> + he_cap->he_cap_elem.phy_cap_info);
> +
> + return ie_len;
There's no value in the "ie_len" variable here.
johannes
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2019-06-14 14:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 19:35 [PATCH v3 0/3] mac80211/ath11k: HE mesh support Sven Eckelmann
2019-06-12 19:35 ` [PATCH v3 1/3] mac80211_hwsim: Register support for HE meshpoint Sven Eckelmann
2019-06-12 19:35 ` [PATCH v3 2/3] mac80211: implement HE support for mesh Sven Eckelmann
2019-06-14 14:11 ` Johannes Berg [this message]
2019-06-14 14:13 ` Sven Eckelmann
2019-06-14 14:14 ` Johannes Berg
2019-06-12 19:35 ` [PATCH v3 3/3] ath11k: register HE mesh capabilities Sven Eckelmann
2019-06-14 14:10 ` [PATCH v3 0/3] mac80211/ath11k: HE mesh support Johannes Berg
2019-07-03 9:23 ` Sven Eckelmann
2019-07-12 7:58 ` Johannes Berg
2019-07-12 9:36 ` Sven Eckelmann
2019-07-12 9:42 ` Johannes Berg
2019-07-12 10:38 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d0d11ca39b6216b24cf4e9e3a1522072db5c0d2.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=seckelmann@datto.com \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox