From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Kalle Valo" <kvalo@kernel.org>
Cc: "Jeff Johnson" <jjohnson@kernel.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Nick Kossifidis" <mickflemm@gmail.com>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
"Loic Poulain" <loic.poulain@linaro.org>,
"Felix Fietkau" <nbd@nbd.name>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"Ryder Lee" <ryder.lee@mediatek.com>,
"Shayne Chen" <shayne.chen@mediatek.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Peter Chiu" <chui-hao.chiu@mediatek.com>,
"Breno Leitao" <leitao@debian.org>,
"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
ath11k@lists.infradead.org, wcn36xx@lists.infradead.org,
brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] wifi: Switch back to struct platform_driver::remove()
Date: Thu, 7 Nov 2024 10:38:11 +0100 [thread overview]
Message-ID: <8f8c6ac8-159a-425e-9d9b-b31c956f700d@broadcom.com> (raw)
In-Reply-To: <20241106170706.38922-2-u.kleine-koenig@baylibre.com>
On 11/6/2024 6:07 PM, Uwe Kleine-König wrote:
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers.
>
> Convert all platform drivers below drivers/net/wireless to use
> .remove(), with the eventual goal to drop struct
> platform_driver::remove_new(). As .remove() and .remove_new() have the
> same prototypes, conversion is done by just changing the structure
> member name in the driver initializer.
>
> En passant several whitespace changes are done to make indentation
> consistent in the struct initializers.
I am fine with the patch as is, but it is really up to Kalle. For
brcmfmac here is my...
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
next prev parent reply other threads:[~2024-11-07 9:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 17:07 [PATCH] wifi: Switch back to struct platform_driver::remove() Uwe Kleine-König
2024-11-06 18:22 ` Jeff Johnson
2024-11-07 9:35 ` Toke Høiland-Jørgensen
2024-11-07 9:38 ` Arend van Spriel [this message]
2024-11-07 10:01 ` Jiri Slaby
2024-11-11 12:10 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f8c6ac8-159a-425e-9d9b-b31c956f700d@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ath10k@lists.infradead.org \
--cc=ath11k@lists.infradead.org \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=chui-hao.chiu@mediatek.com \
--cc=jirislaby@kernel.org \
--cc=jjohnson@kernel.org \
--cc=kvalo@kernel.org \
--cc=leitao@debian.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mcgrof@kernel.org \
--cc=mickflemm@gmail.com \
--cc=nbd@nbd.name \
--cc=rmk+kernel@armlinux.org.uk \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=shayne.chen@mediatek.com \
--cc=toke@toke.dk \
--cc=u.kleine-koenig@baylibre.com \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox