From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Aditya Kumar Singh <quic_adisi@quicinc.com>,
<ath11k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wifi: ath11k: fix band selection for ppdu received in channel 177 of 5 GHz
Date: Wed, 26 Jul 2023 09:54:46 -0700 [thread overview]
Message-ID: <8fe1a927-14da-445c-4c48-e3f4b4c324d4@quicinc.com> (raw)
In-Reply-To: <20230726044624.20507-1-quic_adisi@quicinc.com>
On 7/25/2023 9:46 PM, Aditya Kumar Singh wrote:
> 5 GHz band channel 177 support was added with the commit
> "wifi: ath11k: add channel 177 into 5 GHz channel list". However,
I'd use the same syntax here as in the Fixes tag:
e5e94d10c856 ("wifi: ath11k: add channel 177 into 5 GHz channel list")
> during processing for the received ppdu in ath11k_dp_rx_h_ppdu(), channel
> number is checked only till 173. This leads to driver code checking for
> channel and then fetching the band from it which is extra effort since
> firmware has already given the channel number in the meta deta.
nit: s/meta deta/metadata/
>
> Fix this issue by checking the channel number till 177 since we support
> it now.
>
> Found via code review. Compile tested only.
>
> Fixes: e5e94d10c856 ("wifi: ath11k: add channel 177 into 5 GHz channel list")
> Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com>
> ---
> drivers/net/wireless/ath/ath11k/dp_rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
> index 5c76664ba0dd..1e488eed282b 100644
> --- a/drivers/net/wireless/ath/ath11k/dp_rx.c
> +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
> @@ -2408,7 +2408,7 @@ static void ath11k_dp_rx_h_ppdu(struct ath11k *ar, struct hal_rx_desc *rx_desc,
> rx_status->freq = center_freq;
> } else if (channel_num >= 1 && channel_num <= 14) {
> rx_status->band = NL80211_BAND_2GHZ;
> - } else if (channel_num >= 36 && channel_num <= 173) {
> + } else if (channel_num >= 36 && channel_num <= 177) {
> rx_status->band = NL80211_BAND_5GHZ;
> } else {
> spin_lock_bh(&ar->data_lock);
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2023-07-26 16:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 4:46 [PATCH] wifi: ath11k: fix band selection for ppdu received in channel 177 of 5 GHz Aditya Kumar Singh
2023-07-26 16:54 ` Jeff Johnson [this message]
2023-07-27 6:12 ` Kalle Valo
2023-07-27 12:00 ` Aditya Kumar Singh
2023-07-27 12:02 ` Aditya Kumar Singh
2023-08-02 11:49 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fe1a927-14da-445c-4c48-e3f4b4c324d4@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_adisi@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox