Re: [PATCH v5 2/8] ath11k: add support for 6GHz radio in driver

Wen Gong
2020-09-16T03:56:53Z

On 2020-06-03 08:17, Pradeep Kumar Chitrapu wrote:
> This patch adds 6GHz band support and mac80211 registration for
> the 6G phy radio.
>
> Signed-off-by: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
> ---
> v5:
> - do not add ht/vht caps in 6ghz band.
> v3:
> - update 6GHz starting frequency as defined in IEEE P802.11ax/D6.1
>
> drivers/net/wireless/ath/ath11k/core.h | 6 +-
> drivers/net/wireless/ath/ath11k/mac.c | 93 +++++++++++++++++++++-----
> drivers/net/wireless/ath/ath11k/wmi.c | 16 ++++-
> 3 files changed, 94 insertions(+), 21 deletions(-)
>
[...]
> diff --git a/drivers/net/wireless/ath/ath11k/wmi.c
> b/drivers/net/wireless/ath/ath11k/wmi.c
> index c2a972377687..291fb274134f 100644
> --- a/drivers/net/wireless/ath/ath11k/wmi.c
> +++ b/drivers/net/wireless/ath/ath11k/wmi.c
> @@ -368,6 +368,17 @@ ath11k_pull_mac_phy_cap_svc_ready_ext(struct
> ath11k_pdev_wmi *wmi_handle,
> memcpy(&cap_band->he_ppet, &mac_phy_caps->he_ppet5g,
> sizeof(struct ath11k_ppe_threshold));
>
> + cap_band = &pdev_cap->band[NL80211_BAND_6GHZ];
> + cap_band->max_bw_supported = mac_phy_caps->max_bw_supported_5g;
> + cap_band->ht_cap_info = mac_phy_caps->ht_cap_info_5g;
> + cap_band->he_cap_info[0] = mac_phy_caps->he_cap_info_5g;
> + cap_band->he_cap_info[1] = mac_phy_caps->he_cap_info_5g_ext;
> + cap_band->he_mcs = mac_phy_caps->he_supp_mcs_5g;
> + memcpy(cap_band->he_cap_phy_info, &mac_phy_caps->he_cap_phy_info_5g,
> + sizeof(u32) * PSOC_HOST_MAX_PHY_SIZE);
> + memcpy(&cap_band->he_ppet, &mac_phy_caps->he_ppet5g,
> + sizeof(struct ath11k_ppe_threshold));
> +
> return 0;
> }
>
I want to move this under below check(if (mac_phy_caps->supported_bands
& WMI_HOST_WLAN_5G_CAP) ),
becuase single_pdev
introduced(https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/drivers/net/wireless/ath/ath11k?id=5f859bc02c7bc7a4094bfba0b4ed145edd7661f2)

Is it will distrub your original logic? …