Re: [PATCH v5 2/8] ath11k: add support for 6GHz radio in driver

Wen Gong
2020-09-16T02:34:48Z

On 2020-09-16 07:07, Pradeep Kumar Chitrapu wrote:
>>>>
>>>> - if (cap->supported_bands & WMI_HOST_WLAN_5G_CAP) {
>>>> + if (cap->supported_bands & WMI_HOST_WLAN_5G_CAP &&
>>>> !ar->supports_6ghz) {
>>>> band = &ar->mac.sbands[NL80211_BAND_5GHZ];
>>>> ht_cap = cap->band[NL80211_BAND_5GHZ].ht_cap_info;
>>>> if (ht_cap_info)
>>> After this change, when 6G is support, it removed HT/VHT of 5G band
>>> from "iw list", when connect to an 11AX AP of 5G, it used non-HT.
>>> caused together with this commit
>>> 75e296e9b22aef6fa467523ace87ef623dac1fad(mac80211: simplify and
>>> improve HT/VHT/HE disable code)
>>> + /* disable HT/VHT/HE if we don't support them */
>>> + if (!sband->ht_cap.ht_supported) {
>>> + ifmgd->flags |= IEEE80211_STA_DISABLE_HT;
>>> + ifmgd->flags |= IEEE80211_STA_DISABLE_VHT;
>>> + ifmgd->flags |= IEEE80211_STA_DISABLE_HE;
>>> + }
>>>
>>> after remove this change in ath11k, it become correct to HE
>>> iw wls1 station dump:
>>> rx bitrate: 149.7 MBit/s HE-MCS 6 HE-NSS 2 HE-GI 0 HE-DCM 0
> Hi Wen,
>
> Do you have
> https://lore.kernel.org/linux-wireless/20200528213443.25687d2695bc.I3f9747c1147480f65445f13eda5c4a5ed4e86757@changeid/?
yes, I have it.
>
>>>
>> Hi Pradeep Kumar Chitrapu,
>> For QCA6390, it is single_pdev, the pdev support all 2G/5G/6G,
>> Is it have 3 pdev/ath11k in your chip for 2G/5G/6G?
>> And the pdev/ath11k of 6G have WMI_HOST_WLAN_5G_CAP of
>> cap->supported_bands?
>>> [...]
> Yes, ath11k receives WMI_HOST_WLAN_5G_CAP from firmware for 6G as well.
Ok, so it need to add logic for single_pdev for it(single_pdev is added
in
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/drivers/net/wireless/ath/ath11k?id=5f859bc02c7bc7a4094bfba0b4ed145edd7661f2,
it is later than your 6G patches), maybe I will add it later.