From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Jeff Johnson <quic_jjohnson@quicinc.com>, Kalle Valo <kvalo@kernel.org>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
Kees Cook <keescook@chromium.org>,
ath10k@lists.infradead.org, ath11k@lists.infradead.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] wifi: ath10k: Use DECLARE_FLEX_ARRAY() for ath10k_htc_record
Date: Mon, 27 Nov 2023 10:24:16 -0600 [thread overview]
Message-ID: <99b98f17-3cb2-4658-b183-a0c9d6709d6f@embeddedor.com> (raw)
In-Reply-To: <20231127-flexarray-htc_record-v1-2-6be1f36126fd@quicinc.com>
On 11/27/23 10:14, Jeff Johnson wrote:
> Transform the zero-length arrays in ath10k_htc_record into proper
> flexible arrays via the DECLARE_FLEX_ARRAY() macro. This helps with
> ongoing efforts to globally enable -Warray-bounds.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks
--
Gustavo
> ---
> drivers/net/wireless/ath/ath10k/htc.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/htc.h b/drivers/net/wireless/ath/ath10k/htc.h
> index 9cbb901d35e5..c6c392f8630c 100644
> --- a/drivers/net/wireless/ath/ath10k/htc.h
> +++ b/drivers/net/wireless/ath/ath10k/htc.h
> @@ -246,9 +246,9 @@ struct ath10k_htc_lookahead_bundle {
> struct ath10k_htc_record {
> struct ath10k_ath10k_htc_record_hdr hdr;
> union {
> - struct ath10k_htc_credit_report credit_report[0];
> - struct ath10k_htc_lookahead_report lookahead_report[0];
> - struct ath10k_htc_lookahead_bundle lookahead_bundle[0];
> + DECLARE_FLEX_ARRAY(struct ath10k_htc_credit_report, credit_report);
> + DECLARE_FLEX_ARRAY(struct ath10k_htc_lookahead_report, lookahead_report);
> + DECLARE_FLEX_ARRAY(struct ath10k_htc_lookahead_bundle, lookahead_bundle);
> };
> } __packed __aligned(4);
>
>
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2023-11-27 16:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 16:14 [PATCH 0/4] wifi: ath*: use DECLARE_FLEX_ARRAY() for ath*_htc_record Jeff Johnson
2023-11-27 16:14 ` [PATCH 1/4] wifi: ath10k: remove ath10k_htc_record::pauload[] Jeff Johnson
2023-11-30 17:02 ` Kalle Valo
2023-11-27 16:14 ` [PATCH 2/4] wifi: ath10k: Use DECLARE_FLEX_ARRAY() for ath10k_htc_record Jeff Johnson
2023-11-27 16:24 ` Gustavo A. R. Silva [this message]
2023-11-27 16:14 ` [PATCH 3/4] wifi: ath11k: remove ath11k_htc_record::pauload[] Jeff Johnson
2023-11-27 16:14 ` [PATCH 4/4] wifi: ath11k: Use DECLARE_FLEX_ARRAY() for ath11k_htc_record Jeff Johnson
2023-11-27 16:23 ` Gustavo A. R. Silva
2023-11-27 16:32 ` Jeff Johnson
2023-12-05 15:29 ` Kalle Valo
2023-12-05 15:45 ` Gustavo A. R. Silva
2023-12-05 20:00 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99b98f17-3cb2-4658-b183-a0c9d6709d6f@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=ath10k@lists.infradead.org \
--cc=ath11k@lists.infradead.org \
--cc=gustavoars@kernel.org \
--cc=keescook@chromium.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox