Re: [PATCH] wifi: ath11k: Fix NULL pointer check in ath11k_ce_rx_post_pipe()

[Mihai Moldovan <ionic@ionic.de>]

[-- Attachment #1.1: Type: text/plain, Size: 743 bytes --]

* On 11/25/24 08:37, Baichuan Qi wrote:
> thanks for your reply
> 
>> !(pipe->dest_ring && pipe->status_ring)
> means both pipe->dest_ring and pipe->status_ring must
> be NON-NULL , previous code means ONE of these two rings
> is NON-NULL.

Yes, I understand that, and I already implied that your fix is fine 
functionally. I can also spell it out more directly.

However, I do believe that !pipe->dest_ring || !pipe->status_ring - which is 
functionally equivalent to !(pipe->dest_ring && pipe->status_ring) - is more 
maintainable and easier to parse for humans because it conveys what is meant 
better at a glance - namely that we want to handle the situation as an error if 
any of the given pointers is NULL.



Mihai

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]