From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50B0DC8303C for ; Mon, 7 Jul 2025 13:13:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=88qnIxl1WTM+/s/lulk/yrJSYDtBEUEAd6fSCVve9Q4=; b=I2JtDNNk+z+4GDT5bHPYMTp+j/ VV/fzgZwCbHpeAtoRFMTLB8/KGMi3OgjJhA4FzGx8hWSD6PwwYM3MaHFs2+PcZdKoySxxSihbXqTc NOAOO7CxxpfOI2zWMhSOS41xWFyc85cETro6p5P73aJXnWyvPUpJVdsW/bFWKB+GwgccKhjC0yYyj w+WuqUEBlcex/BN/sTg6+AcQCEyS0dwG8qB+Y+p7ISKTG0ZmQcsZ7bT6JYma4llXeUhnYJ5ZvmSFw CQAoR12XfgXuoDBFFbiDChKR/xcluTXPH2aK5PRYTR0THBNqLQGljEHjtJfs7ilN5aAUFe/QTTRLl o4uzcafg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uYlei-00000002W6h-21xy; Mon, 07 Jul 2025 13:13:12 +0000 Received: from sender4-op-o12.zoho.com ([136.143.188.12]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uYldy-00000002Vx9-04QC for ath11k@lists.infradead.org; Mon, 07 Jul 2025 13:12:27 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1751893886; cv=none; d=zohomail.com; s=zohoarc; b=m7OAsBgLVPt8NhbGdFQF8jF069SVbc5Jg55NGPZVwsf477yyhF0jUSIC0+vmLidfkYCstR4ia9cLytWir7E5+inR8T7TJ19R2tz8w0aIc7yazMgnaRChzYBFUz2JNx9nGXeLvy+v50c9VfB6ZXL2yS57isA6NyKmUovCHd3FvVU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751893886; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=88qnIxl1WTM+/s/lulk/yrJSYDtBEUEAd6fSCVve9Q4=; b=XmMCeayGHQt7623aodPa5qisrj0xsgfuQIi+9wW9hUr0rgWA8nbFaggcSgHRqtXGyY0BJdnmCdU5Y6t0541UjtuUzGzKmg4+jheZNquKwkQCNradkvTlM3diLhqrKKDWPyKVBz85+Zzcqw0yDZsekdy68Wi2A0DAxjKUbyBPzKg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1751893886; s=zohomail; d=collabora.com; i=usama.anjum@collabora.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=88qnIxl1WTM+/s/lulk/yrJSYDtBEUEAd6fSCVve9Q4=; b=DWpR5KjZEJjBLzl75uDVzvaKlFSXN6kWql6zTI1clH6ONk+3hysNbU2R+vNN5FVk SffLW+KmgVi6FuByPR/9chxq6QO/6oiMCFx2OaauyvrhgFO5QLkZj1PzEcNE3HoB527 5u/8lcB0leMeb3f1GZr6WExCDX77Z28aoT+oteEA= Received: by mx.zohomail.com with SMTPS id 1751893882414750.4599650229642; Mon, 7 Jul 2025 06:11:22 -0700 (PDT) Message-ID: <9eba0149-290d-4010-8791-d4d8d8be3786@collabora.com> Date: Mon, 7 Jul 2025 18:11:21 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] bus: mhi: don't deinitialize and re-initialize again To: Baochen Qiang , Manivannan Sadhasivam , Jeff Johnson , Jeff Hugo , Youssef Samir , Matthew Leung , Yan Zhen , Alexander Wilhelm , Alex Elder , Kunwu Chan , Greg Kroah-Hartman , Siddartha Mohanadoss , Sujeev Dias , Julia Lawall , John Crispin , Muna Sinada , Venkateswara Naralasetty , Maharaja Kennadyrajan , mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org Cc: kernel@collabora.com References: <20250630074330.253867-1-usama.anjum@collabora.com> <20250630074330.253867-3-usama.anjum@collabora.com> <5f2a900a-3c8e-4b16-bd91-500af7d0315e@oss.qualcomm.com> <29ba0afa-9a1b-40f9-a174-d03902ea5d3f@collabora.com> <8b9eb6f4-6f0c-458d-b1e6-a1893c35b81d@oss.qualcomm.com> <7b8ea9ba-02ef-4676-a4d3-d088920283c3@oss.qualcomm.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: <7b8ea9ba-02ef-4676-a4d3-d088920283c3@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250707_061226_113952_EE2B45AB X-CRM114-Status: GOOD ( 29.93 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org On 7/7/25 2:00 PM, Baochen Qiang wrote: > > > On 7/7/2025 4:19 PM, Muhammad Usama Anjum wrote: >> On 7/3/25 6:59 AM, Baochen Qiang wrote: >>> >>> >>> On 7/3/2025 12:12 AM, Muhammad Usama Anjum wrote: >>>> Thank you for reviewing. >>>> >>>> On 7/2/25 8:50 AM, Baochen Qiang wrote: >>>>> >>>>> >>>>> On 6/30/2025 3:43 PM, Muhammad Usama Anjum wrote: >>>>>> Don't deinitialize and reinitialize the HAL helpers. The dma memory is >>>>>> deallocated and there is high possibility that we'll not be able to get >>>>>> the same memory allocated from dma when there is high memory pressure. >>>>>> >>>>>> Tested-on: WCN6855 WLAN.HSP.1.1-03926.13-QCAHSPSWPL_V2_SILICONZ_CE-2.52297.6 >>>>>> >>>>>> Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") >>>>>> Signed-off-by: Muhammad Usama Anjum >>>>>> --- >>>>>> drivers/net/wireless/ath/ath11k/core.c | 5 ----- >>>>>> 1 file changed, 5 deletions(-) >>>>>> >>>>>> diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c >>>>>> index 4488e4cdc5e9e..bc4930fe6a367 100644 >>>>>> --- a/drivers/net/wireless/ath/ath11k/core.c >>>>>> +++ b/drivers/net/wireless/ath/ath11k/core.c >>>>>> @@ -2213,14 +2213,9 @@ static int ath11k_core_reconfigure_on_crash(struct ath11k_base *ab) >>>>>> mutex_unlock(&ab->core_lock); >>>>>> >>>>>> ath11k_dp_free(ab); >>>>>> - ath11k_hal_srng_deinit(ab); >>>>>> >>>>>> ab->free_vdev_map = (1LL << (ab->num_radios * TARGET_NUM_VDEVS(ab))) - 1; >>>>>> >>>>>> - ret = ath11k_hal_srng_init(ab); >>>>>> - if (ret) >>>>>> - return ret; >>>>>> - >>>>> >>>>> while I agree there is no need of a dealloc/realloc, we can not simply remove calling the >>>>> _deinit()/_init() pair. At least the memset() cleanup to hal parameters (e.g. >>>> Why do is it being done in the resume handler? Shouldn't those parameters be cleaned up >>>> in resume handler? So when device wakes up, its state is already correct. >>>> >>> >>> Hmm... not quite understand your question. Can you elaborate? >> >> I'm trying to understand the possibility of cleanup of hal in suspend handler. For example: >> * The driver has been loaded and has been working fine. >> * The user called suspend. So all devices would be suspended. >> * In suspend handler of the ath11k, we should do the necessary cleanups of the states >> like hal. >> * When the device would resume after long time, the hal would have the correct state >> already. So we'll not need to deinit and init again. > > The hal cleanup is not only needed by suspend/resume, but also a step of reset/recover > process. So If we are moving the cleanup to suspend handler, similar stuff needs to be > done for reset/recover as well. It makes sense. So clearing the hal structure completely other than ab->hal.srn_config doesn't seem right. I've also tested it and it crashes the whole system. On contrary, with only the current patch applied, there is no abnormality. num_shadow_reg_configured and avail_blk_resource are non-zero. If I make them 0, driver still keeps on working. ab->hal.num_shadow_reg_configured = 0; ab->hal.avail_blk_resource = 0; ab->hal.current_blk_index = 0; As you have suggested setting these 3 to zero, is there any other variable in hal structure which should be set to zero? > >> >>> >>>> I'm not sure why it worked every time when I tested it on my device. >>>> >>>>> avail_blk_resource, current_blk_index and num_shadow_reg_configured etc.) inside the >>>>> _init() needs to be kept as the later operation needs a clean state of them. >>>> So should we just memset these 3? >>> >>> more than them I think. We need to take care of all entries in hal since current code is >>> memset them all. >> I see. So memset the whole ath11k hal structure other than the config. >> >>> >>>> >>>> >>>>> >>>>>> clear_bit(ATH11K_FLAG_CRASH_FLUSH, &ab->dev_flags); >>>>>> >>>>>> ret = ath11k_core_qmi_firmware_ready(ab); >>>>> >>>>> the _deinit() is still getting called in case ath11k_core_qmi_firmware_ready() fails, >>>>> making it a little odd since there is no _init() anymore with this change, though this is >>>>> the way of current logic (I mean the hal is currently deinit in the error path). >>>>> >>>>> Thinking it more, if we hit the error path, seems the only way is to remove ath11k module. >>>>> In that case the _deinit() would be called again in ath11k_pci_remove(), leading to issues >>>>> (at least I see a double free of hal->srng_config). But this is another topic which can be >>>>> fixed in a separate patch. >>>> >>>> I don't think this is the problem as HAL is already initialized when before the system has >>>> suspended. So by removing deinit() and init() pairs, the HAL still remains initialized. Or >>>> maybe I've missed something? >>> >>> Yeah, it is OK in normal path. However in error path we face issues. >> For example: >> * When driver was initialized the first time, the hal was init. >> * Then system was suspended and hal doesn't get deinit. >> * At system resume, the hal is already init. We can memset some status variables. But its >> initialized already from the first time. (considering this patch that deinit/init have >> been removed) >> * So at this stage if some error occurs and we can call the deinit in the error paths. >> >> >