From: Dan Carpenter <dan.carpenter@oracle.com>
To: akolli@codeaurora.org
Cc: ath11k@lists.infradead.org
Subject: [bug report] ath11k: Add qcn9074 mhi controller config
Date: Thu, 18 Mar 2021 16:13:31 +0300 [thread overview]
Message-ID: <YFNR+z1gab7MKkQv@mwanda> (raw)
Hello Anilkumar Kolli,
The patch a233811ef600: "ath11k: Add qcn9074 mhi controller config"
from Feb 16, 2021, leads to the following static checker warning:
drivers/net/wireless/ath/ath11k/mhi.c:357 ath11k_mhi_register()
error: uninitialized symbol 'ath11k_mhi_config'.
drivers/net/wireless/ath/ath11k/mhi.c
342 mhi_ctrl->iova_stop = 0xffffffff;
343 mhi_ctrl->sbl_size = SZ_512K;
344 mhi_ctrl->seg_len = SZ_512K;
345 mhi_ctrl->fbc_download = true;
346 mhi_ctrl->runtime_get = ath11k_mhi_op_runtime_get;
347 mhi_ctrl->runtime_put = ath11k_mhi_op_runtime_put;
348 mhi_ctrl->status_cb = ath11k_mhi_op_status_cb;
349 mhi_ctrl->read_reg = ath11k_mhi_op_read_reg;
350 mhi_ctrl->write_reg = ath11k_mhi_op_write_reg;
351
352 if (ab->hw_rev == ATH11K_HW_QCA6390_HW20)
353 ath11k_mhi_config = &ath11k_mhi_config_qca6390;
354 else if (ab->hw_rev == ATH11K_HW_QCN9074_HW10)
355 ath11k_mhi_config = &ath11k_mhi_config_qcn9074;
ath11k_mhi_config not initialized for other revs. Which seem to exist
so this seems like it could be a real bug?
356
357 ret = mhi_register_controller(mhi_ctrl, ath11k_mhi_config);
358 if (ret) {
359 ath11k_err(ab, "failed to register to mhi bus, err = %d\n", ret);
360 mhi_free_controller(mhi_ctrl);
361 return ret;
362 }
363
364 return 0;
365 }
regards,
dan carpenter
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next reply other threads:[~2021-03-18 13:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 13:13 Dan Carpenter [this message]
2021-03-19 8:19 ` [bug report] ath11k: Add qcn9074 mhi controller config akolli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFNR+z1gab7MKkQv@mwanda \
--to=dan.carpenter@oracle.com \
--cc=akolli@codeaurora.org \
--cc=ath11k@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox