ATH11K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Aloka Dixit <aloka.dixit@oss.qualcomm.com>
To: Jeff Johnson <jeff.johnson@oss.qualcomm.com>,
	ath11k@lists.infradead.org, ath12k@lists.infradead.org,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 1/5] wifi: ath11k: refactor transmitted arvif retrieval
Date: Mon, 3 Feb 2025 13:45:19 -0800	[thread overview]
Message-ID: <a612fb4c-ba9c-41ef-99df-6c26039d86ef@oss.qualcomm.com> (raw)
In-Reply-To: <85216244-8348-4fc0-957d-6ffbcbcdb28b@oss.qualcomm.com>

On 1/29/2025 3:52 PM, Jeff Johnson wrote:
> On 1/18/2025 9:22 PM, aloka.dixit@oss.qualcomm.com wrote:
> 
> ...
> 
>> @@ -1538,7 +1546,7 @@ static int ath11k_mac_setup_bcn_tmpl_ema(struct ath11k_vif *arvif)
>>   	u32 params = 0;
>>   	u8 i = 0;
>>   
>> -	tx_arvif = ath11k_vif_to_arvif(arvif->vif->mbssid_tx_vif);
>> +	tx_arvif = ath11k_mac_get_tx_arvif(arvif);
>>   
>>   	beacons = ieee80211_beacon_get_template_ema_list(tx_arvif->ar->hw,
>>   							 tx_arvif->vif, 0);
>> @@ -1597,7 +1605,7 @@ static int ath11k_mac_setup_bcn_tmpl_mbssid(struct ath11k_vif *arvif)
>>   	int ret;
>>   
>>   	if (vif->mbssid_tx_vif) {
> 
> can/should we remove this test since ath11k_mac_get_tx_arvif() already does
> this test? note ath11k_control_beaconing() removes the test

Sure, sent v3 now.
Thanks.


  reply	other threads:[~2025-02-03 21:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-19  5:22 [PATCH v2 0/5] wifi:ath11k/ath12k: refactor tx_arvif retrieval aloka.dixit
2025-01-19  5:22 ` [PATCH v2 1/5] wifi: ath11k: refactor transmitted arvif retrieval aloka.dixit
2025-01-29 23:52   ` Jeff Johnson
2025-02-03 21:45     ` Aloka Dixit [this message]
2025-01-19  5:22 ` [PATCH v2 2/5] wifi: ath11k: pass tx arvif for MBSSID and EMA beacon generation aloka.dixit
2025-01-19  5:22 ` [PATCH v2 3/5] wifi: ath12k: refactor transmitted arvif retrieval aloka.dixit
2025-01-19  5:22 ` [PATCH v2 4/5] wifi: ath12k: pass tx arvif for MBSSID and EMA beacon generation aloka.dixit
2025-01-19  5:22 ` [PATCH v2 5/5] wifi: ath12k: pass BSSID index as input for EMA aloka.dixit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a612fb4c-ba9c-41ef-99df-6c26039d86ef@oss.qualcomm.com \
    --to=aloka.dixit@oss.qualcomm.com \
    --cc=ath11k@lists.infradead.org \
    --cc=ath12k@lists.infradead.org \
    --cc=jeff.johnson@oss.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox