ATH11K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Karthikeyan periyasamy <periyasa@codeaurora.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCH 1/2] ath11k: Add direct buffer ring support
Date: Tue, 09 Jun 2020 13:05:43 +0530	[thread overview]
Message-ID: <b48ac64d3defa14e65ca1fa40b65b857@codeaurora.org> (raw)
In-Reply-To: <20200609063958.C3869C43391@smtp.codeaurora.org>

>> Add direct buffer ring (dbring) with helper API, which is used by the
>> spectral scan. Initialise the direct buffer ring based on the dma ring
>> capability, which get announced in the wmi service ready extended 
>> event.
>> This ring is slightly changed from data path rings. Compare to data 
>> path
>> ring this ring shares the hp and tp address to firmware though WMI 
>> commands.
>> Also the replenish buffer size is derived from firmware announcement.
>> driver receive indication through WMI event
>> WMI_PDEV_DMA_RING_BUF_RELEASE_EVENTID.
>> 
>> Tested-on: IPQ8074 WLAN.HK.2.1.0.1-01228-QCAHKSWPL_SILICONZ-1
>> 
>> Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>
> 
> Fails to build:
> 
> Error in reading or end of file.
> drivers/net/wireless/ath/ath11k/dbring.c: In function
> 'ath11k_dbring_buffer_release_event':
> drivers/net/wireless/ath/ath11k/dbring.c:271:8: error: assignment to
> 'struct ath11k_dbring *' from incompatible pointer type 'struct
> ath11k_db_ring *' [-Werror=incompatible-pointer-types]
>   271 |   ring = ath11k_spectral_get_dbring(ar);
>       |        ^
> cc1: some warnings being treated as errors
> make[5]: *** [drivers/net/wireless/ath/ath11k/dbring.o] Error 1
> make[5]: *** Waiting for unfinished jobs....
> make[4]: *** [drivers/net/wireless/ath/ath11k] Error 2
> make[4]: *** Waiting for unfinished jobs....
> make[3]: *** [drivers/net/wireless/ath] Error 2
> make[2]: *** [drivers/net/wireless] Error 2
> make[1]: *** [drivers/net] Error 2
> make: *** [drivers] Error 2
> 
> 2 patches set to Changes Requested.
> 
> 11594295 [1/2] ath11k: Add direct buffer ring support
> 11594297 [2/2] ath11k: add support for spectral scan


My bad, fixed this build error in the next version patch

Thanks,
Karthikeyan

_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

      parent reply	other threads:[~2020-06-09  7:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09  3:39 [PATCH 1/2] ath11k: Add direct buffer ring support Karthikeyan Periyasamy
2020-06-09  3:39 ` [PATCH 2/2] ath11k: add support for spectral scan Karthikeyan Periyasamy
2020-06-09  6:39 ` [PATCH 1/2] ath11k: Add direct buffer ring support Kalle Valo
     [not found] ` <20200609063958.C3869C43391@smtp.codeaurora.org>
2020-06-09  7:35   ` Karthikeyan periyasamy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b48ac64d3defa14e65ca1fa40b65b857@codeaurora.org \
    --to=periyasa@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox