ATH11K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Aditya Kumar Singh <quic_adisi@quicinc.com>
To: Kang Yang <quic_kangyang@quicinc.com>, <ath11k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v5 2/2] wifi: ath11k: update channel list in worker when wait flag is set
Date: Tue, 21 Jan 2025 14:33:45 +0530	[thread overview]
Message-ID: <bb4e2001-dea8-4efc-ae3a-babcce8acb0f@quicinc.com> (raw)
In-Reply-To: <20250117061737.1921-3-quic_kangyang@quicinc.com>

On 1/17/25 11:47, Kang Yang wrote:
> From: Wen Gong <quic_wgong@quicinc.com>
> 
> With previous patch "wifi: ath11k: move update channel list from update
> reg worker to reg notifier", ath11k_reg_update_chan_list() will be
> called during reg_process_self_managed_hint().
> 
> reg_process_self_managed_hint() will hold rtnl_lock all the time.
> But ath11k_reg_update_chan_list() may increase the occupation time of
> rtnl_lock, because when wait flag is set, wait_for_completion_timeout()
> will be called during 11d/hw scan.
> 
> Should minimize the occupation time of rtnl_lock as much as possible
> to avoid interfering with rest of the system. So move the update channel
> list operation to a new worker, so that wait_for_completion_timeout()
> won't be called and will not increase the occupation time of rtnl_lock.
> 
> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
> 
> Signed-off-by: Wen Gong <quic_wgong@quicinc.com>
> Co-developed-by: Kang Yang <quic_kangyang@quicinc.com>
> Signed-off-by: Kang Yang <quic_kangyang@quicinc.com>
> ---

Reviewed-by: Aditya Kumar Singh <quic_adisi@quicinc.com>


-- 
Aditya


  reply	other threads:[~2025-01-21  9:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-17  6:17 [PATCH v5 0/2] wifi: ath11k: fix data out of sync for channel list for reg update Kang Yang
2025-01-17  6:17 ` [PATCH v5 1/2] wifi: ath11k: update channel list in reg notifier instead reg worker Kang Yang
2025-01-21  9:03   ` Aditya Kumar Singh
2025-01-17  6:17 ` [PATCH v5 2/2] wifi: ath11k: update channel list in worker when wait flag is set Kang Yang
2025-01-21  9:03   ` Aditya Kumar Singh [this message]
2025-01-21  8:00 ` [PATCH v5 0/2] wifi: ath11k: fix data out of sync for channel list for reg update Kang Yang
2025-02-05  1:44   ` Jeff Johnson
2025-02-06  0:16 ` Jeff Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb4e2001-dea8-4efc-ae3a-babcce8acb0f@quicinc.com \
    --to=quic_adisi@quicinc.com \
    --cc=ath11k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_kangyang@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox